Changeset 81347 in webkit

Timestamp:

Mar 17, 2011 5:00:34 AM (13 years ago)

Author:

kov@webkit.org

Message:

2011-03-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Andreas Kling.

Tiled backing store should only request repaint for updated areas
​https://bugs.webkit.org/show_bug.cgi?id=56464

Reuse updateBackBuffer's dirty rectangle calculations to only
invalidate the necessary parts of the window.

• platform/graphics/Tile.h:
• platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::updateTileBuffers):
• platform/graphics/qt/TileQt.cpp: (WebCore::Tile::updateBackBuffer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/Tile.h (modified) (1 diff)
• platform/graphics/TiledBackingStore.cpp (modified) (2 diffs)
• platform/graphics/qt/TileQt.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
+
+        Reviewed by Andreas Kling.
+
+        Tiled backing store should only request repaint for updated areas
+        https://bugs.webkit.org/show_bug.cgi?id=56464
+
+        Reuse updateBackBuffer's dirty rectangle calculations to only
+        invalidate the necessary parts of the window.
+
+        * platform/graphics/Tile.h:
+        * platform/graphics/TiledBackingStore.cpp:
+        (WebCore::TiledBackingStore::updateTileBuffers):
+        * platform/graphics/qt/TileQt.cpp:
+        (WebCore::Tile::updateBackBuffer):
+
 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
 

trunk/Source/WebCore/platform/graphics/Tile.h

@@ -50 +50 @@
     bool isDirty() const;
     void invalidate(const IntRect&);
-    void updateBackBuffer();
+    Vector<IntRect> updateBackBuffer();
     void swapBackBufferToFront();
     bool isReadyToPaint() const;

trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp

@@ -103 +103 @@
             continue;
         dirtyTiles.append(it->second);
-        // FIXME: should not request system repaint for the full tile.
-        paintedArea.append(mapToContents(it->second->rect()));
     }
     
@@ -116 +114 @@
     // blocking on tile updates.
     unsigned size = dirtyTiles.size();
-    for (unsigned n = 0; n < size; ++n)
-        dirtyTiles[n]->updateBackBuffer();
-
-    for (unsigned n = 0; n < size; ++n)
+    for (unsigned n = 0; n < size; ++n) {
+        Vector<IntRect> paintedRects = dirtyTiles[n]->updateBackBuffer();
+        paintedArea.append(paintedRects);
         dirtyTiles[n]->swapBackBufferToFront();
+    }
 
     m_client->tiledBackingStorePaintEnd(paintedArea);

trunk/Source/WebCore/platform/graphics/qt/TileQt.cpp

@@ -92 +92 @@
 }
     
-void Tile::updateBackBuffer()
+Vector<IntRect> Tile::updateBackBuffer()
 {
     if (m_buffer && !isDirty())
-        return;
+        return Vector<IntRect>();
 
     if (!m_backBuffer) {
@@ -116 +116 @@
     context.translate(-m_rect.x(), -m_rect.y());
 
+    Vector<IntRect> updatedRects;
     int size = dirtyRects.size();
     for (int n = 0; n < size; ++n)  {
         context.save();
         IntRect rect = dirtyRects[n];
+        updatedRects.append(rect);
         context.clip(FloatRect(rect));
         context.scale(FloatSize(m_backingStore->m_contentsScale, m_backingStore->m_contentsScale));
@@ -125 +127 @@
         context.restore();
     }
+
+    return updatedRects;
 }