Changeset 81489 in webkit


Ignore:
Timestamp:
Mar 18, 2011 11:14:14 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-03-18 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
​https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
​https://bugs.webkit.org/show_bug.cgi?id=50112
​https://bugs.webkit.org/show_bug.cgi?id=51989
​https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/chromium/test_expectations.txt:

2011-03-18 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
​https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
​https://bugs.webkit.org/show_bug.cgi?id=50112
​https://bugs.webkit.org/show_bug.cgi?id=51989
​https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r81488 r81489  
     12011-03-18  Justin Novosad  <junov@chromium.org>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        [Chromium] Canvas shadow is not working with drawImage
     6        https://bugs.webkit.org/show_bug.cgi?id=55506
     7
     8        Patch also fixes shadow blur quality and color.
     9        Affects Chromium win/linux. Also fixes the following bugs:
     10        https://bugs.webkit.org/show_bug.cgi?id=50112
     11        https://bugs.webkit.org/show_bug.cgi?id=51989
     12        https://bugs.webkit.org/show_bug.cgi?id=55410
     13        No tests were added, impact is already covered by multiple layout tests.
     14
     15        * platform/chromium/test_expectations.txt:
     16
    1172011-03-18  Jessie Berlin  <jberlin@apple.com>
    218

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r81469 r81489  
    20432043BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.canvas.transparent.2.html = TEXT
    20442044BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.enable.blur.html = TEXT
    2045 BUGWK15266 LINUX WIN : canvas/philip/tests/2d.shadow.gradient.alpha.html = TEXT
    2046 BUGWK15266 LINUX WIN : canvas/philip/tests/2d.shadow.gradient.basic.html = TEXT
    2047 BUGWK15266 LINUX WIN : canvas/philip/tests/2d.shadow.gradient.transparent.2.html = TEXT
    20482045BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.alpha.html = TEXT
    20492046BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.basic.html = TEXT
    20502047BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.scale.html = TEXT
    20512048BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.image.transparent.2.html = TEXT
    2052 BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.pattern.alpha.html = TEXT
    2053 BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.pattern.basic.html = TEXT
    2054 BUGWK45991 LINUX WIN : canvas/philip/tests/2d.shadow.pattern.transparent.2.html = TEXT
    20552049BUGWK45991 CPU LINUX WIN : canvas/philip/tests/2d.transformation.setTransform.skewed.html = TEXT
    20562050BUGWK45991 CPU LINUX WIN : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT
    … …  
    25842578// Mainly flaky with mac debug, but also intermittent crashes seen on linux release
    25852579BUGCR64129 MAC LINUX : fast/files/revoke-blob-url.html = CRASH PASS
    2586 
    2587 // Unknown reason. Was introduced at r72588
    2588 BUG_LOISLO WIN LINUX : fast/canvas/canvas-drawImage-shadow.html = TEXT
    2589 
    2590 BUGWK50112 WIN LINUX : fast/canvas/canvas-createPattern-fillRect-shadow.html = TEXT
    2591 
    2592 BUGCR64647 WIN LINUX : fast/canvas/canvas-scale-drawImage-shadow.html = TEXT
    25932580
    25942581BUGCR64672 : fast/regex/invalid-range-in-class.html = TEXT
    … …  
    27942781BUGWK52082 WIN LINUX : fast/text/basic/014.html = IMAGE+TEXT
    27952782BUGWK52082 WIN LINUX : fast/text/midword-break-after-breakable-char.html = IMAGE+TEXT
    2796 
    2797 // These were introduced by r75139
    2798 BUGWK51989 WIN LINUX : fast/canvas/canvas-fillRect-gradient-shadow.html = TEXT
    27992783
    28002784// These have been flaky for as long as we have test history.
    … …  
    32323216BUGWK56072 WIN-VISTA : fast/ruby/base-shorter-than-text.html = FAIL
    32333217
     3218// Added by junov temporary test failures until blur rendering is re-baselined
     3219BUGCR42654 WIN LINUX : fast/blockflow/english-lr-text.html = IMAGE
     3220BUGCR42654 WIN LINUX : fast/borders/border-radius-split-inline.html = IMAGE
     3221BUGCR42654 WIN LINUX : fast/box-shadow/basic-shadows.html = IMAGE
     3222BUGCR42654 WIN LINUX : fast/box-shadow/border-radius-big.html = IMAGE
     3223BUGCR42654 WIN LINUX : fast/box-shadow/box-shadow-radius.html = IMAGE
     3224BUGCR42654 WIN LINUX : fast/box-shadow/box-shadow-transformed.html = IMAGE
     3225BUGCR42654 WIN LINUX : fast/box-shadow/inset-box-shadow-radius.html = IMAGE
     3226BUGCR42654 WIN LINUX : fast/box-shadow/inset-box-shadows.html = IMAGE
     3227BUGCR42654 WIN LINUX : fast/box-shadow/inset.html = IMAGE
     3228BUGCR42654 WIN LINUX : fast/box-shadow/shadow-buffer-partial.html = IMAGE
     3229BUGCR42654 WIN LINUX : fast/box-shadow/shadow-tiling-artifact.html = IMAGE
     3230BUGCR42654 WIN LINUX : fast/box-shadow/spread-multiple-normal.html = IMAGE
     3231BUGCR42654 WIN LINUX : fast/box-shadow/spread.html = IMAGE
     3232BUGCR42654 WIN LINUX : fast/multicol/shadow-breaking.html = IMAGE
     3233BUGCR42654 WIN LINUX : fast/repaint/box-shadow-h.html = IMAGE
     3234BUGCR42654 WIN LINUX : fast/repaint/box-shadow-v.html = IMAGE
     3235BUGCR42654 WIN LINUX : fast/repaint/moving-shadow-on-container.html = IMAGE
     3236BUGCR42654 WIN LINUX : fast/repaint/moving-shadow-on-path.html = IMAGE
     3237BUGCR42654 WIN LINUX : fast/repaint/shadow-multiple-horizontal.html = IMAGE
     3238BUGCR42654 WIN LINUX : fast/repaint/shadow-multiple-strict-horizontal.html = IMAGE
     3239BUGCR42654 WIN LINUX : fast/repaint/shadow-multiple-strict-vertical.html = IMAGE
     3240BUGCR42654 WIN LINUX : fast/repaint/shadow-multiple-vertical.html = IMAGE
     3241BUGCR42654 WIN LINUX : fast/repaint/transform-replaced-shadows.html = IMAGE
     3242BUGCR42654 WIN LINUX : fast/text/shadow-translucent-fill.html = IMAGE
     3243BUGCR42654 WIN LINUX : fast/text/stroking-decorations.html = IMAGE
     3244BUGCR42654 WIN LINUX : fast/text/stroking.html = IMAGE
     3245BUGCR42654 WIN LINUX : fast/transforms/shadows.html = IMAGE
     3246BUGCR42654 WIN LINUX : svg/css/arrow-with-shadow.svg = IMAGE
     3247BUGCR42654 WIN LINUX : svg/css/composite-shadow-example.html = IMAGE
     3248BUGCR42654 WIN LINUX : svg/css/composite-shadow-text.svg = IMAGE
     3249BUGCR42654 WIN LINUX : svg/css/composite-shadow-with-opacity.html = IMAGE
     3250BUGCR42654 WIN LINUX : svg/css/group-with-shadow.svg = IMAGE
     3251BUGCR42654 WIN LINUX : svg/css/shadow-changes.svg = IMAGE
     3252BUGCR42654 WIN LINUX : svg/css/shadow-with-large-radius.svg = IMAGE
     3253BUGCR42654 WIN LINUX : svg/css/shadow-with-negative-offset.svg = IMAGE
     3254BUGCR42654 WIN LINUX : svg/css/stars-with-shadow.html = IMAGE
     3255BUGCR42654 WIN LINUX : svg/css/text-gradient-shadow.svg = IMAGE
     3256BUGCR42654 WIN LINUX : svg/css/text-shadow-multiple.xhtml = IMAGE
     3257BUGCR42654 WIN LINUX : transitions/svg-text-shadow-transition.html = IMAGE
     3258BUGCR42654 WIN LINUX : compositing/geometry/clipping-foreground.html = IMAGE
     3259BUGCR42654 WIN LINUX : compositing/iframes/composited-iframe-alignment.html = IMAGE
     3260
    32343261// introduced by Dave Hyatt in WK r80582
    32353262BUGCR75561 WIN LINUX : fast/blockflow/text-orientation-basic.html = IMAGE+TEXT

  • trunk/Source/WebCore/ChangeLog

    r81487 r81489  
     12011-03-18  Justin Novosad  <junov@chromium.org>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        [Chromium] Canvas shadow is not working with drawImage
     6        https://bugs.webkit.org/show_bug.cgi?id=55506
     7
     8        Patch also fixes shadow blur quality and color.
     9        Affects Chromium win/linux. Also fixes the following bugs:
     10        https://bugs.webkit.org/show_bug.cgi?id=50112
     11        https://bugs.webkit.org/show_bug.cgi?id=51989
     12        https://bugs.webkit.org/show_bug.cgi?id=55410
     13        No tests were added, impact is already covered by multiple layout tests.
     14
     15        * platform/graphics/skia/GraphicsContextSkia.cpp:
     16        (WebCore::GraphicsContext::setPlatformShadow):
     17        * platform/graphics/skia/ImageSkia.cpp:
     18        (WebCore::paintSkBitmap):
     19
    1202011-03-15  Alexander Pavlov  <apavlov@chromium.org>
    221

  • trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

    r81361 r81489  
    10361036    double blur = blurFloat;
    10371037
    1038     SkBlurDrawLooper::BlurFlags blurFlags = SkBlurDrawLooper::kNone_BlurFlag;
     1038    uint32_t blurFlags = SkBlurDrawLooper::kHighQuality_BlurFlag |
     1039        SkBlurDrawLooper::kOverrideColor_BlurFlag;
    10391040
    10401041    if (m_state.shadowsIgnoreTransforms)  {
    … …  
    10431044        // Transforms. So with this flag set, we know this state is associated
    10441045        // with a CanvasRenderingContext.
    1045         blurFlags = SkBlurDrawLooper::kIgnoreTransform_BlurFlag;
     1046        blurFlags |= SkBlurDrawLooper::kIgnoreTransform_BlurFlag;
    10461047       
    10471048        // CG uses natural orientation for Y axis, but the HTML5 canvas spec

  • trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp

    r80519 r81489  
    261261    paint.setFilterBitmap(true);
    262262    paint.setAlpha(platformContext->getNormalizedAlpha());
     263    paint.setLooper(platformContext->getDrawLooper());
    263264
    264265    skia::PlatformCanvas* canvas = platformContext->canvas();
Note: See TracChangeset for help on using the changeset viewer.