Changeset 81618 in webkit


Ignore:
Timestamp:
Mar 21, 2011 4:19:13 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-03-21 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable/disable a GestureReocognizer framework

​https://bugs.webkit.org/show_bug.cgi?id=49345

  • wtf/Platform.h:

2011-03-21 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Add Support to WebCore to optionally call a platform-specific gesture recognizer
​https://bugs.webkit.org/show_bug.cgi?id=49345

Added an ability for the EventHandler to invoke an optional platform
specific gesture recognizer.

No tests added because the change should be functionally invisible.

  • WebCore.gypi:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:
  • platform/PlatformGestureRecognizer.cpp: Added. (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::create):
  • platform/PlatformGestureRecognizer.h: Added.

2011-03-21 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable a platform specific GestureReocognizer framework in Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=49345

  • features.gypi:
Location:
trunk/Source
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r81610 r81618  
     12011-03-21  Robert Kroeger  <rjkroege@chromium.org>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        Flag to enable/disable a GestureReocognizer framework
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=49345
     8
     9        * wtf/Platform.h:
     10
    1112011-03-21  Adam Barth  <abarth@webkit.org>
    212

  • trunk/Source/JavaScriptCore/wtf/Platform.h

    r81379 r81618  
    963963#endif
    964964
     965#if !defined(ENABLE_GESTURE_RECOGNIZER)
     966#define ENABLE_GESTURE_RECOGNIZER 0
     967#endif
     968
    965969#if !defined(ENABLE_NOTIFICATIONS)
    966970#define ENABLE_NOTIFICATIONS 0

  • trunk/Source/WebCore/ChangeLog

    r81613 r81618  
     12011-03-21  Robert Kroeger  <rjkroege@chromium.org>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        Add Support to WebCore to optionally call a platform-specific gesture recognizer
     6        https://bugs.webkit.org/show_bug.cgi?id=49345
     7
     8        Added an ability for the EventHandler to invoke an optional platform
     9        specific gesture recognizer.
     10
     11        No tests added because the change should be functionally invisible.
     12
     13        * WebCore.gypi:
     14        * page/EventHandler.cpp:
     15        (WebCore::EventHandler::EventHandler):
     16        (WebCore::EventHandler::handleTouchEvent):
     17        * page/EventHandler.h:
     18        * platform/PlatformGestureRecognizer.cpp: Added.
     19        (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
     20        (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
     21        (WebCore::PlatformGestureRecognizer::create):
     22        * platform/PlatformGestureRecognizer.h: Added.
     23
    1242011-03-21  Dean Jackson  <dino@apple.com>
    225

  • trunk/Source/WebCore/WebCore.gypi

    r81540 r81618  
    953953            'platform/NotImplemented.h',
    954954            'platform/PlatformGestureEvent.h',
     955            'platform/PlatformGestureRecognizer.cpp',
     956            'platform/PlatformGestureRecognizer.h',
    955957            'platform/PlatformKeyboardEvent.h',
    956958            'platform/PlatformMenuDescription.h',

  • trunk/Source/WebCore/page/EventHandler.cpp

    r81209 r81618  
    9696#endif
    9797
     98#if ENABLE(ENABLE_GESTURE_RECOGNIZER)
     99#include "PlatformGestureRecognizer.h"
     100#endif
     101
    98102namespace WebCore {
    99103
    … …  
    202206#if ENABLE(TOUCH_EVENTS)
    203207    , m_touchPressed(false)
     208#endif
     209#if ENABLE(ENABLE_GESTURE_RECOGNIZER)
     210    , m_gestureRecognizer(PlatformGestureRecognizer::create())
    204211#endif
    205212{
    … …  
    31023109    }
    31033110
     3111#if ENABLE(ENABLE_GESTURE_RECOGNIZER)
     3112    if (m_gestureRecognizer)
     3113        m_gestureRecognizer->processTouchEventForGesture(event, this, defaultPrevented);
     3114#endif
     3115
    31043116    return defaultPrevented;
    31053117}

  • trunk/Source/WebCore/page/EventHandler.h

    r80172 r81618  
    3535#include "Timer.h"
    3636#include <wtf/Forward.h>
     37#include <wtf/OwnPtr.h>
    3738#include <wtf/RefPtr.h>
    3839
    … …  
    7778#endif
    7879
     80#if ENABLE(ENABLE_GESTURE_RECOGNIZER)
     81class PlatformGestureRecognizer;
     82#endif
     83
    7984#if ENABLE(DRAG_SUPPORT)
    8085extern const int LinkDragHysteresis;
    … …  
    451456    bool m_touchPressed;
    452457#endif
     458#if ENABLE(ENABLE_GESTURE_RECOGNIZER)
     459    OwnPtr<PlatformGestureRecognizer> m_gestureRecognizer;
     460#endif
    453461};
    454462

  • trunk/Source/WebKit/chromium/ChangeLog

    r81614 r81618  
     12011-03-21  Robert Kroeger  <rjkroege@chromium.org>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        Flag to enable a platform specific GestureReocognizer framework in Chromium.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=49345
     8
     9        * features.gypi:
     10
    1112011-03-21  Tony Chang  <tony@chromium.org>
    212

  • trunk/Source/WebKit/chromium/features.gypi

    r81596 r81618  
    6060        'ENABLE_FULLSCREEN_API=1',
    6161        'ENABLE_GEOLOCATION=1',
     62        'ENABLE_GESTURE_RECOGNIZER=1',
    6263        'ENABLE_ICONDATABASE=0',
    6364        'ENABLE_INDEXED_DATABASE=1',
Note: See TracChangeset for help on using the changeset viewer.