Changeset 81621 in webkit


Ignore:
Timestamp:
Mar 21, 2011 5:11:44 PM (13 years ago)
Author:
abarth@webkit.org
Message:

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn't crash on startup
​https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/JavaScriptCore.gyp:

2011-03-21 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn&apos;t crash on startup
​https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/WebCore.gyp:
Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r81618 r81621  
     12011-03-21  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        WebCore GYP build shouldn't crash on startup
     6        https://bugs.webkit.org/show_bug.cgi?id=56776
     7
     8        Debug builds shouldn't define NDEBUG.  This same logic exists in the
     9        project.pbxproj file.
     10
     11        * gyp/JavaScriptCore.gyp:
     12
    1132011-03-21  Robert Kroeger  <rjkroege@chromium.org>
    214

  • trunk/Source/JavaScriptCore/gyp/JavaScriptCore.gyp

    r80906 r81621  
    5454        '<@(javascriptcore_include_dirs)',
    5555      ],
     56      'configurations': {
     57        'Production': {
     58        },
     59        'Release': {
     60          'xcode_settings': {
     61            'STRIP_INSTALLED_PRODUCT': 'NO',
     62          },
     63        },
     64        'Debug': {
     65          'xcode_settings': {
     66            'DEAD_CODE_STRIPPING': '$(DEAD_CODE_STRIPPING_debug)',
     67            'DEBUG_DEFINES': '$(DEBUG_DEFINES_debug)',
     68            'GCC_OPTIMIZATION_LEVEL': '$(GCC_OPTIMIZATION_LEVEL_debug)',
     69            'STRIP_INSTALLED_PRODUCT': '$(STRIP_INSTALLED_PRODUCT_debug)',
     70          },
     71        },
     72      },
    5673      'sources': [
    5774        '<@(javascriptcore_files)',

  • trunk/Source/WebCore/ChangeLog

    r81620 r81621  
     12011-03-21  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        WebCore GYP build shouldn&apos;t crash on startup
     6        https://bugs.webkit.org/show_bug.cgi?id=56776
     7
     8        Debug builds shouldn't define NDEBUG.  This same logic exists in the
     9        project.pbxproj file.
     10
     11        * gyp/WebCore.gyp:
     12
    1132011-03-21  Daniel Cheng  <dcheng@chromium.org>
    214

  • trunk/Source/WebCore/gyp/WebCore.gyp

    r81540 r81621  
    2525        '<(PRODUCT_DIR)/DerivedSources/WebCore',
    2626      ],
     27      'configurations': {
     28        'Production': {
     29        },
     30        'Release': {
     31          'xcode_settings': {
     32            'STRIP_INSTALLED_PRODUCT': 'NO',
     33          },
     34        },
     35        'Debug': {
     36          'xcode_settings': {
     37            'DEAD_CODE_STRIPPING': '$(DEAD_CODE_STRIPPING_debug)',
     38            'DEBUG_DEFINES': '$(DEBUG_DEFINES_debug)',
     39            'GCC_OPTIMIZATION_LEVEL': '$(GCC_OPTIMIZATION_LEVEL_debug)',
     40            'STRIP_INSTALLED_PRODUCT': '$(STRIP_INSTALLED_PRODUCT_debug)',
     41          },
     42        },
     43      },
    2744      'sources': [
    2845        '<@(webcore_files)',
    … …  
    153170            'INFOPLIST_FILE': '<(DEPTH)/WebCore/Info.plist',
    154171            'ALWAYS_SEARCH_USER_PATHS': 'NO',
    155             'DEAD_CODE_STRIPPING': 'NO',
    156172          },
    157173        }],
Note: See TracChangeset for help on using the changeset viewer.