Changeset 82030 in webkit

Timestamp:

Mar 26, 2011 7:38:43 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-03-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

We shouldn't bother running GYP if the generated files are newer than the GYP files
​https://bugs.webkit.org/show_bug.cgi?id=57146

In the common case, this check will avoid any overhead from processing
the GYP files. Another approach to doing this is to add the feature to
GYP directly, but GYP's approach to this problem is to compute the
output in its entirety and compare it byte-for-byte against the output
file. In the future, it might make sense to add this approach as an
alternative approach for GYP itself.

I also removed JavaScriptGlue from the script because we're not really
going to change JavaScriptGlue over to GYP. We were using
JavaScriptGlue as a learning experience.

• Source/gyp/configure:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/gyp/configure (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2011-03-26  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        We shouldn't bother running GYP if the generated files are newer than the GYP files
+        https://bugs.webkit.org/show_bug.cgi?id=57146
+
+        In the common case, this check will avoid any overhead from processing
+        the GYP files.  Another approach to doing this is to add the feature to
+        GYP directly, but GYP's approach to this problem is to compute the
+        output in its entirety and compare it byte-for-byte against the output
+        file.  In the future, it might make sense to add this approach as an
+        alternative approach for GYP itself.
+
+        I also removed JavaScriptGlue from the script because we're not really
+        going to change JavaScriptGlue over to GYP.  We were using
+        JavaScriptGlue as a learning experience.
+
+        * Source/gyp/configure:
+
 2011-03-25  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/Source/gyp/configure

@@ -32 +32 @@
 import subprocess
 
+from optparse import OptionParser
+
+def chdir_to_source():
+    source_directory = os.path.abspath(os.path.join(__file__, '..', '..'))
+    os.chdir(source_directory)
+
+def gyp():
+    return os.path.join('ThirdParty', 'gyp', 'gyp')
+
+class Project:
+    def __init__(self, name):
+        self._name = name
+
+    def name(self):
+        return self._name
+
+    def inputs(self):
+        return [
+            os.path.join(self._name, 'gyp', self._name + '.gyp'),
+            os.path.join(self._name, self._name + '.gypi'),
+            os.path.join('gyp', 'common.gypi'),
+        ]
+
+    def output(self):
+        return os.path.join(self._name, 'gyp', self._name + '.xcodeproj', 'project.pbxproj')
+
+    def should_generate(self):
+        if not os.path.exists(self.output()):
+            return True
+        return os.path.getmtime(self.output()) < self._newest(self.inputs())
+
+    def generate(self):
+        subprocess.call([
+            gyp(),
+            self.inputs()[0],
+            '-G',
+            'xcode_list_excluded_files=0',
+            '--depth=.',
+        ])
+        # GYP doesn't always touch the output file, but we want to touch the
+        # file so that we don't keep trying to regenerate it.
+        os.utime(self.output(), None)
+
+    @staticmethod
+    def _newest(paths):
+        return max([os.path.getmtime(path) for path in paths])
 
 PROJECTS = [
-    "JavaScriptGlue",
-    "JavaScriptCore",
-    "WebCore",
+    Project("JavaScriptCore"),
+    Project("WebCore"),
 ]
 
+def projects_to_generate():
+    should_generate = [project for project in PROJECTS if project.should_generate()]
+    already_generated = [project.name() for project in set(PROJECTS) - set(should_generate)]
 
-def create_project(project):
-    subprocess.call([
-        os.path.join('ThirdParty', 'gyp', 'gyp'),
-        os.path.join(project, 'gyp', project + '.gyp'),
-        '-G',
-        'xcode_list_excluded_files=0',
-        '--depth=.',
-    ])
+    if already_generated:
+        print "Not generating %s because the generated files exist and are newer than the GYP files." % ', '.join(already_generated)
+        print "Pass --regenerate-projects to override."
 
-
-def create_all_projects():
-    for project in PROJECTS:
-        create_project(project)
-
+    return should_generate
 
 def main():
-    source_directory = os.path.abspath(os.path.join(__file__, '..', '..'))
-    os.chdir(source_directory)
+    chdir_to_source()
+
+    parser = OptionParser()
     # FIXME: The user should be able to pass which port on the command line.
-    create_all_projects()
+    parser.add_option("--regenerate-projects", dest="regenerate_projects",
+                      default=False, action="store_true",
+                      help="Generate all project files even if they appear to be up to date.")
+    (options, args) = parser.parse_args()
 
+    projects = PROJECTS
+    if not options.regenerate_projects:
+        projects = projects_to_generate()
+
+    for project in projects:
+        print "Generating %s." % project.name()
+        project.generate()
 
 if __name__ == "__main__":