Changeset 82215 in webkit


Ignore:
Timestamp:
Mar 29, 2011 1:55:16 AM (13 years ago)
Author:
eric@webkit.org
Message:

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Add support for parsing unicode-bidi: -webkit-isolate
https://bugs.webkit.org/show_bug.cgi?id=57181

  • css3/unicode-bidi-insolate-parse-expected.txt: Added.
  • css3/unicode-bidi-insolate-parse.html: Added.

2011-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Add support for parsing unicode-bidi: -webkit-isolate
https://bugs.webkit.org/show_bug.cgi?id=57181

Test: css3/unicode-bidi-insolate-parse.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r82213 r82215  
     12011-03-29  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Ryosuke Niwa.
     4
     5        Add support for parsing unicode-bidi: -webkit-isolate
     6        https://bugs.webkit.org/show_bug.cgi?id=57181
     7
     8        * css3/unicode-bidi-insolate-parse-expected.txt: Added.
     9        * css3/unicode-bidi-insolate-parse.html: Added.
     10
    1112011-03-29  Philippe Normand  <pnormand@igalia.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r82214 r82215  
     12011-03-29  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Ryosuke Niwa.
     4
     5        Add support for parsing unicode-bidi: -webkit-isolate
     6        https://bugs.webkit.org/show_bug.cgi?id=57181
     7
     8        Test: css3/unicode-bidi-insolate-parse.html
     9
     10        * WebCore.xcodeproj/project.pbxproj:
     11        * css/CSSParser.cpp:
     12        (WebCore::CSSParser::parseValue):
     13        * css/CSSPrimitiveValueMappings.h:
     14        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     15        (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
     16        * css/CSSValueKeywords.in:
     17        * rendering/style/RenderStyleConstants.h:
     18
    1192011-03-29  Patrick Gansterer  <paroga@webkit.org>
    220
  • trunk/Source/WebCore/css/CSSParser.cpp

    r81943 r82215  
    648648            return parseQuotes(propId, important);
    649649        break;
    650     case CSSPropertyUnicodeBidi:         // normal | embed | bidi-override | inherit
    651         if (id == CSSValueNormal ||
    652              id == CSSValueEmbed ||
    653              id == CSSValueBidiOverride)
     650    case CSSPropertyUnicodeBidi: // normal | embed | bidi-override | isolate | inherit
     651        if (id == CSSValueNormal
     652            || id == CSSValueEmbed
     653            || id == CSSValueBidiOverride
     654            || id == CSSValueWebkitIsolate)
    654655            validPrimitive = true;
    655656        break;
  • trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h

    r82105 r82215  
    17421742{
    17431743    switch (e) {
    1744         case UBNormal:
    1745             m_value.ident = CSSValueNormal;
    1746             break;
    1747         case Embed:
    1748             m_value.ident = CSSValueEmbed;
    1749             break;
    1750         case Override:
    1751             m_value.ident = CSSValueBidiOverride;
    1752             break;
     1744    case UBNormal:
     1745        m_value.ident = CSSValueNormal;
     1746        break;
     1747    case Embed:
     1748        m_value.ident = CSSValueEmbed;
     1749        break;
     1750    case Override:
     1751        m_value.ident = CSSValueBidiOverride;
     1752        break;
     1753    case Isolate:
     1754        m_value.ident = CSSValueWebkitIsolate;
    17531755    }
    17541756}
     
    17571759{
    17581760    switch (m_value.ident) {
    1759         case CSSValueNormal:
    1760             return UBNormal;
    1761         case CSSValueEmbed:
    1762             return Embed;
    1763         case CSSValueBidiOverride:
    1764             return Override;
    1765         default:
    1766             ASSERT_NOT_REACHED();
    1767             return UBNormal;
     1761    case CSSValueNormal:
     1762        return UBNormal;
     1763    case CSSValueEmbed:
     1764        return Embed;
     1765    case CSSValueBidiOverride:
     1766        return Override;
     1767    case CSSValueWebkitIsolate:
     1768        return Isolate;
     1769    default:
     1770        ASSERT_NOT_REACHED();
     1771        return UBNormal;
    17681772    }
    17691773}
  • trunk/Source/WebCore/css/CSSValueKeywords.in

    r81684 r82215  
    407407higher
    408408invert
     409-webkit-isolate
    409410landscape
    410411ledger
  • trunk/Source/WebCore/rendering/style/RenderStyleConstants.h

    r82105 r82215  
    122122
    123123enum EUnicodeBidi {
    124     UBNormal, Embed, Override
     124    UBNormal, Embed, Override, Isolate
    125125};
    126126
Note: See TracChangeset for help on using the changeset viewer.