Changeset 82400 in webkit

Timestamp:

Mar 30, 2011 12:00:25 AM (13 years ago)

Author:

tkent@chromium.org

Message:

2011-03-30 Kent Tamura <​tkent@chromium.org>

Reviewed by Ojan Vafai.

H1 element should have different default style if it is in HTML5 sectioning elements.
​https://bugs.webkit.org/show_bug.cgi?id=52693

• fast/css/h1-in-section-elements.html: Added.
• platform/mac/fast/css/h1-in-section-elements-expected.checksum: Added.
• platform/mac/fast/css/h1-in-section-elements-expected.png: Added.
• platform/mac/fast/css/h1-in-section-elements-expected.txt: Added.

2011-03-30 Kent Tamura <​tkent@chromium.org>

Reviewed by Ojan Vafai.

H1 element should have different default style if it is in HTML5 sectioning elements.
​https://bugs.webkit.org/show_bug.cgi?id=52693

Test: fast/css/h1-in-section-elements.html

• css/html.css: Add font-size and margin declarations to follow HTML5 specification. (:-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/h1-in-section-elements.html (added)
• LayoutTests/platform/mac/fast/css/h1-in-section-elements-expected.checksum (added)
• LayoutTests/platform/mac/fast/css/h1-in-section-elements-expected.png (added)
• LayoutTests/platform/mac/fast/css/h1-in-section-elements-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/html.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-03-30  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        H1 element should have different default style if it is in HTML5 sectioning elements.
+        https://bugs.webkit.org/show_bug.cgi?id=52693
+
+        * fast/css/h1-in-section-elements.html: Added.
+        * platform/mac/fast/css/h1-in-section-elements-expected.checksum: Added.
+        * platform/mac/fast/css/h1-in-section-elements-expected.png: Added.
+        * platform/mac/fast/css/h1-in-section-elements-expected.txt: Added.
+
 2011-03-29  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-30  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        H1 element should have different default style if it is in HTML5 sectioning elements.
+        https://bugs.webkit.org/show_bug.cgi?id=52693
+
+        Test: fast/css/h1-in-section-elements.html
+
+        * css/html.css: Add font-size and margin declarations to follow HTML5 specification.
+        (:-webkit-any(article,aside,nav,section) h1):
+        (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
+        (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
+        (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
+        (:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
+
 2011-03-29  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/css/html.css

@@ -153 +153 @@
 }
 
+:-webkit-any(article,aside,nav,section) h1 {
+    font-size: 1.5em;
+    -webkit-margin-before: 0.83__qem;
+    -webkit-margin-after: 0.83em;
+}
+
+:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1 {
+    font-size: 1.17em;
+    -webkit-margin-before: 1__qem;
+    -webkit-margin-after: 1em;
+}
+
+:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1 {
+    font-size: 1.00em;
+    -webkit-margin-before: 1.33__qem;
+    -webkit-margin-after: 1.33em;
+}
+
+:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1 {
+    font-size: .83em;
+    -webkit-margin-before: 1.67__qem;
+    -webkit-margin-after: 1.67em;
+}
+
+:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1 {
+    font-size: .67em;
+    -webkit-margin-before: 2.33__qem;
+    -webkit-margin-after: 2.33em;
+}
+
 h2 {
     display: block;