Changeset 82461 in webkit

Timestamp:

Mar 30, 2011 10:10:25 AM (13 years ago)

Author:

yael.aharon@nokia.com

Message:

2011-03-30 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Eric Seidel.

REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
​https://bugs.webkit.org/show_bug.cgi?id=57442

When checking the position of the inline iterator in the logicallyLastRun, we should not consider BR as text.

No new tests as existing test covers this case.

• rendering/RenderBlockLineLayout.cpp: (WebCore::reachedEndOfTextRenderer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockLineLayout.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-30  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
+        https://bugs.webkit.org/show_bug.cgi?id=57442
+
+        When checking the position of the inline iterator in the logicallyLastRun, we should not consider BR as text.
+
+        No new tests as existing test covers this case.
+
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::reachedEndOfTextRenderer):
+
 2011-03-30  Mario Sanchez Prada  <msanchez@igalia.com>
 

trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -616 +616 @@
     unsigned int pos = run->stop();
     RenderObject* r = run->m_object;
-    if (!r->isText())
+    if (!r->isText() || r->isBR())
         return false;
     RenderText* renderText = toRenderText(r);