Changeset 82610 in webkit


Ignore:
Timestamp:
Mar 31, 2011 1:21:07 PM (13 years ago)
Author:
Adam Roben
Message:

Quote the executable path we pass to ::CreateProcessW

This will ensure that spaces in the path will be interpreted correctly.

Fixes <http://webkit.org/b/57569> Web process sometimes fails to launch when there are
spaces in its path

Reviewed by Steve Falkenburg.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess): Surround the executable path in quotes.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r82603 r82610  
     12011-03-31  Adam Roben  <aroben@apple.com>
     2
     3        Quote the executable path we pass to ::CreateProcessW
     4
     5        This will ensure that spaces in the path will be interpreted correctly.
     6
     7        Fixes <http://webkit.org/b/57569> Web process sometimes fails to launch when there are
     8        spaces in its path
     9
     10        Reviewed by Steve Falkenburg.
     11
     12        * UIProcess/Launcher/win/ProcessLauncherWin.cpp:
     13        (WebKit::ProcessLauncher::launchProcess): Surround the executable path in quotes.
     14
    1152011-03-31  Alexey Proskuryakov  <ap@apple.com>
    216
  • trunk/Source/WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp

    r76916 r82610  
    7777    // FIXME: It would be nice if we could just create a CommandLine object and output a command line vector from it.
    7878    Vector<UChar> commandLineVector;
     79    append(commandLineVector, "\"");
    7980    append(commandLineVector, commandLine);
     81    append(commandLineVector, "\"");
    8082    append(commandLineVector, " -type webprocess");
    8183    append(commandLineVector, " -clientIdentifier ");
Note: See TracChangeset for help on using the changeset viewer.