Changeset 82721 in webkit

Timestamp:

Apr 1, 2011 2:36:20 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-01 Dominic Cooney <​dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=57551

• platform/gtk/Skipped: unskip test that accesses shadowRoot

2011-04-01 Dominic Cooney <​dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=57551

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):
• WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-01 Dominic Cooney <​dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=57551

• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowRoot):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Source/WebKit/gtk/ChangeLog (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (modified) (2 diffs)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-01  Dominic Cooney  <dominicc@google.com>
+
+        Reviewed by Martin Robinson.
+
+        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
+        https://bugs.webkit.org/show_bug.cgi?id=57551
+
+        * platform/gtk/Skipped: unskip test that accesses shadowRoot
+
 2011-04-01  Darin Adler  <darin@apple.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -474 +474 @@
 # https://bugs.webkit.org/show_bug.cgi?id=54136
 fast/html/keygen.html
-
-# layoutTestController does not implement shadowRoot accessor
-# See https://bugs.webkit.org/show_bug.cgi?id=56573
-fast/dom/HTMLKeygenElement/keygen.html
 
 # [GTK] GTK+ does not support hyphenation

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-04-01  Dominic Cooney  <dominicc@google.com>
+
+        Reviewed by Martin Robinson.
+
+        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
+        https://bugs.webkit.org/show_bug.cgi?id=57551
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (DumpRenderTreeSupportGtk::shadowRoot):
+        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+
 2011-03-31  Xan Lopez  <xlopez@igalia.com>
 

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

@@ -29 +29 @@
 #include "DOMWrapperWorld.h"
 #include "Document.h"
+#include "Element.h"
 #include "FocusController.h"
 #include "FrameLoaderClientGtk.h"
@@ -637 +638 @@
 }
 
+JSValueRef DumpRenderTreeSupportGtk::shadowRoot(JSContextRef context, JSValueRef value)
+{
+    JSC::ExecState* exec = toJS(context);
+    Element* element = toElement(toJS(exec, value));
+    if (!element)
+      return JSValueMakeNull(context);
+
+    return toRef(exec, toJS(exec, element->shadowRoot()));
+}
+
 unsigned int DumpRenderTreeSupportGtk::workerThreadCount()
 {

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

@@ -62 +62 @@
     static void clearOpener(WebKitWebFrame*);
 
+    static JSValueRef shadowRoot(JSContextRef, JSValueRef);
+
     // FIXME: Move these to webkitwebframe.h once their API has been discussed.
     static GSList* getFrameChildren(WebKitWebFrame*);

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-01  Dominic Cooney  <dominicc@google.com>
+
+        Reviewed by Martin Robinson.
+
+        Add layoutTestController.shadowRoot to GTK DumpRenderTree.
+        https://bugs.webkit.org/show_bug.cgi?id=57551
+
+        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+        (LayoutTestController::shadowRoot):
+
 2011-04-01  Sam Weinig  <sam@webkit.org>
 

trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

@@ -918 +918 @@
 }
 
-JSValueRef LayoutTestController::shadowRoot(JSContextRef context, JSValueRef jsElement)
-{
-    // FIXME: Implement this.
-    return JSValueMakeUndefined(context);
+JSValueRef LayoutTestController::shadowRoot(JSContextRef context, JSValueRef element)
+{
+    return DumpRenderTreeSupportGtk::shadowRoot(context, element);
 }