Changeset 82807 in webkit

Timestamp:

Apr 4, 2011 2:03:03 AM (13 years ago)

Author:

loislo@chromium.org

Message:

2011-04-04 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove obsolete doc generating code from CodeGenerator.
​https://bugs.webkit.org/show_bug.cgi?id=57748

• inspector/CodeGeneratorInspector.pm:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/CodeGeneratorInspector.pm (modified) (9 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-04  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: remove obsolete doc generating code from CodeGenerator.
+        https://bugs.webkit.org/show_bug.cgi?id=57748
+
+        * inspector/CodeGeneratorInspector.pm:
+
 2011-04-04  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm

@@ -106 +106 @@
     "JSONType" => "Object",
     "JSType" => "object",
-    "DocType" => "%s"
 };
 $typeTransform{"Array"} = {
@@ -116 +115 @@
     "JSONType" => "Array",
     "JSType" => "object",
-    "DocType" => "array of %s"
 };
 $typeTransform{"Value"} = {
@@ -126 +124 @@
     "JSONType" => "Value",
     "JSType" => "",
-    "DocType" => "value"
 };
 $typeTransform{"String"} = {
@@ -237 +234 @@
 my @frontendFooter;
 
-my @documentationToc;
-my @documentationLines;
-
 # Default constructor
 sub new
@@ -347 +341 @@
             generateBackendFunction($interface, $function);
         }
-    }
-
-    push(@documentationToc, "<li><a href='#" . $interface->name . "'>" . $interface->name . "</a></li>");
-    push(@documentationLines, "<h2 id='" . $interface->name . "'><a name=" . $interface->name . "></a>" . $interface->name . "</h2>");
-
-    push(@documentationLines, "<h3>Events</h3>");
-    foreach my $function (grep($_->signature->extendedAttributes->{"event"}, @{$interface->functions}) ) {
-        generateDocumentationEvent($interface, $function);
-    }
-
-    push(@documentationLines, "<h3>Commands</h3>");
-    foreach my $function (grep(!$_->signature->extendedAttributes->{"event"}, @{$interface->functions})) {
-        generateDocumentationCommand($interface, $function);
     }
 
@@ -400 +381 @@
 }
 
-sub generateDocumentationEvent
-{
-    my $interface = shift;
-    my $function = shift;
-
-    my $functionName = $function->signature->name;
-    my $domain = $interface->name;
-
-    my @argsFiltered = grep($_->direction eq "out", @{$function->parameters});
-
-    my @lines;
-    push(@lines, "<h4>" . $interface->name . "." . ${functionName} . "</h4>");
-    my $doc = $function->signature->extendedAttributes->{"doc"};
-    if ($doc) {
-        push(@lines, $doc);
-    }
-
-    push(@lines, "<pre style='background: lightGrey; padding: 10px'>");
-    push(@lines, "{");
-    push(@lines, "    type: \"event\",");
-    push(@lines, "    domain: \"$domain\",");
-    if (scalar(@argsFiltered)) {
-        push(@lines, "    event: \"${functionName}\",");
-        push(@lines, "    data: {");
-        my @parameters;
-        foreach my $parameter (@argsFiltered) {
-            push(@parameters, "        " . parameterDocLine($parameter));
-        }
-        push(@lines, join(",\n", @parameters));
-        push(@lines, "    }");
-    } else {
-        push(@lines, "    event: \"${functionName}\"");
-    }
-    push(@lines, "}");
-    push(@lines, "</pre>");
-    push(@documentationLines, @lines);
-}
-
 sub camelCase
 {
@@ -541 +484 @@
 }
 
-sub generateDocumentationCommand
-{
-    my $interface = shift;
-    my $function = shift;
-
-    my $functionName = $function->signature->name;
-    my $domain = $interface->name;
-
-    my @lines;
-
-    push(@lines, "<h4>" . $interface->name . "." . ${functionName} . "</h4>");
-    my $doc = $function->signature->extendedAttributes->{"doc"};
-    if ($doc) {
-        push(@lines, $doc);
-    }
-
-    my @inArgs = grep($_->direction eq "in" && !($_->name eq "callId") , @{$function->parameters});
-    push(@lines, "<pre style='background: lightGrey; padding: 10px'>");
-    push(@lines, "request: {");
-    push(@lines, "    id: &lt;number&gt;,");
-    push(@lines, "    type: \"request\",");
-    push(@lines, "    domain: \"" . $interface->name . "\",");
-    if (scalar(@inArgs)) {
-        push(@lines, "    command: \"${functionName}\",");
-        push(@lines, "    arguments: {");
-        my @parameters;
-        foreach my $parameter (@inArgs) {
-            push(@parameters, "        " . parameterDocLine($parameter));
-        }
-        push(@lines, join(",\n", @parameters));
-        push(@lines, "    }");
-    } else {
-        push(@lines, "    command: \"${functionName}\"");
-    }
-    push(@lines, "}");
-
-    my @outArgs = grep($_->direction eq "out", @{$function->parameters});    
-    push(@lines, "");
-    push(@lines, "response: {");
-    push(@lines, "    requestId: &lt;number&gt;,");
-    if (scalar(@outArgs)) {
-        push(@lines, "    type: \"response\",");
-        push(@lines, "    body: {");
-            my @parameters;
-            foreach my $parameter (@outArgs) {
-                push(@parameters, "        " . parameterDocLine($parameter));
-            }
-            push(@lines, join(",\n", @parameters));
-        push(@lines, "    }");
-    } else {
-        push(@lines, "    type: \"response\"");
-    }
-    push(@lines, "}");
-    push(@lines, "</pre>");
-
-    push(@documentationLines, @lines);
-}
-
 sub generateBackendReportProtocolError
 {
@@ -1041 +926 @@
 }
 
-sub parameterDocType
-{
-    my $parameter = shift;
-    my $subtype = $parameter->extendedAttributes->{"type"};
-    if ($subtype) {
-        my $pattern = typeTraits($parameter->type, "DocType");
-        return sprintf($pattern, "&lt;$subtype&gt;");
-    }
-
-    my $subtypeRef = $parameter->extendedAttributes->{"typeRef"};
-    if ($subtypeRef) {
-        my $pattern = typeTraits($parameter->type, "DocType");
-        return sprintf($pattern, "&lt;<a href='#$subtypeRef'>" . $subtypeRef . "</a>&gt;");
-    }
-
-    return "&lt;" . typeTraits($parameter->type, "JSType") . "&gt;";
-}
-
-sub parameterDocLine
-{
-    my $parameter = shift;
-
-    my $result = $parameter->name . ": " . parameterDocType($parameter);
-    my $doc = $parameter->extendedAttributes->{"doc"};
-    if ($doc) {
-        $result = $result . " // " . $doc;
-    }
-    return $result;
-}
-
 sub generateBackendAgentFieldsAndConstructor
 {
@@ -1152 +1007 @@
     close($JS_STUB);
     undef($JS_STUB);
-
-    open(my $DOCS, ">$outputDir/WebInspectorProtocol.html") || die "Couldn't open file $outputDir/WebInspectorProtocol.html";
-    print $DOCS "<ol class='toc' style='list-style: none; padding: 0'>";
-    print $DOCS join("\n", @documentationToc);
-    print $DOCS "</ol>";
-    print $DOCS join("\n", @documentationLines);
-    close($DOCS);
-    undef($DOCS);
 }