Changeset 82822 in webkit

Timestamp:

Apr 4, 2011 4:33:44 AM (13 years ago)

Author:

apavlov@chromium.org

Message:

2011-04-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
​https://bugs.webkit.org/show_bug.cgi?id=48525

• inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/Resource.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-04  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
+        https://bugs.webkit.org/show_bug.cgi?id=48525
+
+        * inspector/front-end/Resource.js:
+        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
+
 2011-04-01  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/Resource.js

@@ -567 +567 @@
         // as it's going to be an error message. We do not want to emit a warning
         // for this, though, as this will already be reported as resource loading failure.
-        if (this.statusCode >= 400)
+        // Also, if a URL like http://localhost/wiki/load.php?debug=true&lang=en produces text/css and gets reloaded,
+        // it is 304 Not Modified and its guessed mime-type is text/php, which is wrong.
+        // Don't check for mime-types in 304-resources.
+        if (this.statusCode >= 400 || this.statusCode === 304)
             return true;