Changeset 82830 in webkit
- Timestamp:
- Apr 4, 2011 7:17:40 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r82828 r82830 1 2011-04-04 Pavel Podivilov <podivilov@chromium.org> 2 3 Reviewed by Yury Semikhatsky. 4 5 Web Inspector: search in resources panel is broken. 6 https://bugs.webkit.org/show_bug.cgi?id=57631 7 8 Search in resources panel should trigger source frame content load. 9 10 * inspector/front-end/Panel.js: 11 (WebInspector.Panel.prototype.jumpToNextSearchResult): 12 (WebInspector.Panel.prototype.jumpToPreviousSearchResult): 13 * inspector/front-end/ResourcesPanel.js: 14 * inspector/front-end/SearchController.js: 15 (WebInspector.SearchController.prototype.handleShortcut): 16 (WebInspector.SearchController.prototype.focusSearchField): 17 * inspector/front-end/SourceFrame.js: 18 (WebInspector.SourceFrame.prototype.show): 19 (WebInspector.SourceFrame.prototype._ensureContentLoaded): 20 (WebInspector.SourceFrame.prototype.performSearch): 21 1 22 2011-04-03 Eric Seidel <eric@webkit.org> 2 23 -
trunk/Source/WebCore/inspector/front-end/Panel.js
r82685 r82830 236 236 if (currentView !== this.visibleView) { 237 237 this.showView(currentView); 238 WebInspector. focusSearchField();238 WebInspector.searchController.focusSearchField(); 239 239 } 240 240 … … 269 269 if (currentView !== this.visibleView) { 270 270 this.showView(currentView); 271 WebInspector. focusSearchField();271 WebInspector.searchController.focusSearchField(); 272 272 } 273 273 -
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
r82685 r82830 694 694 695 695 const visibleView = this.visibleView; 696 if (visibleView .performSearch)696 if (visibleView && visibleView.performSearch) 697 697 views.push(visibleView); 698 698 -
trunk/Source/WebCore/inspector/front-end/SearchController.js
r80102 r82830 85 85 86 86 if (isFindKey) { 87 this. _focusSearchField();87 this.focusSearchField(); 88 88 event.handled = true; 89 89 } … … 93 93 case "F3": 94 94 if (!isMac) { 95 this. _focusSearchField();95 this.focusSearchField(); 96 96 event.handled = true; 97 97 } … … 158 158 }, 159 159 160 _focusSearchField: function()160 focusSearchField: function() 161 161 { 162 162 this.element.focus(); -
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
r82808 r82830 64 64 WebInspector.View.prototype.show.call(this, parentElement); 65 65 66 if (!this._contentRequested) { 67 this._contentRequested = true; 68 this._delegate.requestContent(this._createTextViewer.bind(this)); 69 } 66 this._ensureContentLoaded(); 70 67 71 68 if (this._textViewer) { … … 100 97 { 101 98 return true; 99 }, 100 101 _ensureContentLoaded: function() 102 { 103 if (!this._contentRequested) { 104 this._contentRequested = true; 105 this._delegate.requestContent(this._createTextViewer.bind(this)); 106 } 102 107 }, 103 108 … … 347 352 this._delayedFindSearchMatches = doFindSearchMatches.bind(this, query); 348 353 354 this._ensureContentLoaded(); 349 355 }, 350 356
Note: See TracChangeset
for help on using the changeset viewer.