Changeset 82915 in webkit


Ignore:
Timestamp:
Apr 5, 2011 2:17:53 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-05 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

[chromium] Specify 'sans-serif' as a fallback to the default UI font
'Arial' for non-latin UI scripts (e.g. CJK).
https://bugs.webkit.org/show_bug.cgi?id=55035

No new tests, because it may still fail if the system is not configured
properly to resolve 'sans-serif' to existing real font file, thus even
manual test is hard to systematically tell it is working properly.

  • rendering/RenderThemeChromiumSkia.cpp
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r82908 r82915  
     12011-04-05  Takayoshi Kochi <kochi@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        [chromium] Specify 'sans-serif' as a fallback to the default UI font
     6        'Arial' for non-latin UI scripts (e.g. CJK).
     7        https://bugs.webkit.org/show_bug.cgi?id=55035
     8
     9        No new tests, because it may still fail if the system is not configured
     10        properly to resolve 'sans-serif' to existing real font file, thus even
     11        manual test is hard to systematically tell it is working properly.
     12
     13        * rendering/RenderThemeChromiumSkia.cpp
     14
    1152011-04-05  Kent Tamura  <tkent@chromium.org>
    216
  • trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.cpp

    r76379 r82915  
    7777// FIXME: The only case where we know we don't match IE is for ANSI encodings.
    7878// IE uses MS Shell Dlg there, which we render incorrectly at certain pixel
    79 // sizes (e.g. 15px). So, for now we just use Arial.
     79// sizes (e.g. 15px). So, for now we just use Arial. For other non-latin
     80// scripts (e.g. CJK) that Arial does not cover, we specify sans-serif as a
     81// fallback.
    8082const String& RenderThemeChromiumSkia::defaultGUIFont()
    8183{
    82     DEFINE_STATIC_LOCAL(String, fontFace, ("Arial"));
     84    DEFINE_STATIC_LOCAL(String, fontFace, ("Arial, sans-serif"));
    8385    return fontFace;
    8486}
Note: See TracChangeset for help on using the changeset viewer.