Changeset 83045 in webkit


Ignore:
Timestamp:
Apr 6, 2011 7:29:02 AM (13 years ago)
Author:
podivilov@chromium.org
Message:

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

  • inspector/debugger/script-formatter-expected.txt: Added.
  • inspector/debugger/script-formatter.html: Added.
  • platform/chromium/test_expectations.txt:

2011-03-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
​https://bugs.webkit.org/show_bug.cgi?id=57447

Test: inspector/debugger/script-formatter.html

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83039 r83045  
     12011-03-30  Pavel Podivilov  <podivilov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: add test for script formatter worker.
     6        https://bugs.webkit.org/show_bug.cgi?id=57447
     7
     8        * inspector/debugger/script-formatter-expected.txt: Added.
     9        * inspector/debugger/script-formatter.html: Added.
     10        * platform/chromium/test_expectations.txt:
     11
    1122011-04-06  Ryosuke Niwa  <rniwa@webkit.org>
    213

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r83027 r83045  
    162162WONTFIX SKIP : http/tests/eventsource/workers = PASS TIMEOUT FAIL
    163163WONTFIX SKIP : http/tests/websocket/tests/workers/ = PASS TIMEOUT FAIL
     164WONTFIX SKIP : inspector/debugger/script-formatter.html = PASS TIMEOUT FAIL
    164165
    165166// Page Cache - based tests. Chromium disables page cache because the WebKit page cache keeps previously

  • trunk/Source/WebCore/ChangeLog

    r83044 r83045  
     12011-03-30  Pavel Podivilov  <podivilov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: add test for script formatter worker.
     6        https://bugs.webkit.org/show_bug.cgi?id=57447
     7
     8        Test: inspector/debugger/script-formatter.html
     9
     10        * GNUmakefile.am:
     11        * inspector/front-end/DebuggerPresentationModel.js:
     12        (WebInspector.DebuggerPresentationModel):
     13        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
     14
    1152011-04-06  Martin Robinson  <mrobinson@igalia.com>
    216

  • trunk/Source/WebCore/GNUmakefile.am

    r82962 r83045  
    53165316        DerivedSources/WebCore/InspectorBackendStub.js \
    53175317        $(shell ls $(WebCore)/inspector/front-end/*.js) \
     5318        $(shell ls $(WebCore)/inspector/front-end/UglifyJS/*.js) \
    53185319        $(shell ls $(WebCore)/inspector/front-end/*.html) \
    53195320        $(shell ls $(WebCore)/inspector/front-end/*.css)
    … …  
    53295330${GENSOURCES_INSPECTOR}/inspector.html: $(WebCore)/inspector/front-end/*.html \
    53305331                $(WebCore)/inspector/front-end/*.js \
     5332                $(WebCore)/inspector/front-end/UglifyJS/*.js \
    53315333                $(WebCore)/inspector/front-end/*.css \
    53325334                $(WebCore)/inspector/front-end/Images/* \

  • trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

    r82685 r83045  
    106106            sourceFile = new WebInspector.SourceFile(sourceFileId, script, contentChanged.bind(this));
    107107        else
    108             sourceFile = new WebInspector.FormattedSourceFile(sourceFileId, script, contentChanged.bind(this), this._formatter);
     108            sourceFile = new WebInspector.FormattedSourceFile(sourceFileId, script, contentChanged.bind(this), this._formatter());
    109109        this._sourceFiles[sourceFileId] = sourceFile;
    110110        this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.SourceFileAdded, sourceFile);
    … …  
    186186    {
    187187        this._formatSourceFiles = !this._formatSourceFiles;
    188         if (this._formatSourceFiles && !this._formatter)
    189             this._formatter = new WebInspector.ScriptFormatter();
    190188
    191189        var messages = this._messages;
    … …  
    205203        if (WebInspector.debuggerModel.callFrames)
    206204            this._debuggerPaused();
     205    },
     206
     207    _formatter: function()
     208    {
     209        if (!this._scriptFormatter)
     210            this._scriptFormatter = new WebInspector.ScriptFormatter();
     211        return this._scriptFormatter;
    207212    },
    208213
Note: See TracChangeset for help on using the changeset viewer.