Changeset 83049 in webkit

Timestamp:

Apr 6, 2011 7:57:21 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-06 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

[Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
​https://bugs.webkit.org/show_bug.cgi?id=57800
<rdar://problem/9218223>

Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.

• accessibility/AXObjectCache.h:
• accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
• accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postPlatformNotification):
• editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AXObjectCache.h (modified) (1 diff)
• accessibility/chromium/AXObjectCacheChromium.cpp (modified) (1 diff)
• accessibility/mac/AXObjectCacheMac.mm (modified) (1 diff)
• editing/Editor.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-06  Jia Pu  <jpu@apple.com>
+
+        Reviewed by Darin Adler.
+
+        [Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
+        https://bugs.webkit.org/show_bug.cgi?id=57800
+        <rdar://problem/9218223>
+
+        Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
+        now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.
+
+        * accessibility/AXObjectCache.h:
+        * accessibility/chromium/AXObjectCacheChromium.cpp:
+        (WebCore::AXObjectCache::postPlatformNotification):
+        * accessibility/mac/AXObjectCacheMac.mm:
+        (WebCore::AXObjectCache::postPlatformNotification):
+        * editing/Editor.cpp:
+        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
+
 2011-04-06  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/accessibility/AXObjectCache.h

@@ -119 +119 @@
     enum AXNotification {
         AXActiveDescendantChanged,
+        AXAutocorrectionOccured,
         AXCheckedStateChanged,
         AXChildrenChanged,

trunk/Source/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp

@@ -77 +77 @@
         handleFocusedUIElementChanged(0, obj->document()->focusedNode()->renderer());
         break;
+    case AXAutocorrectionOccured:
     case AXCheckedStateChanged:
     case AXChildrenChanged:

trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm

@@ -71 +71 @@
                 macNotification = NSAccessibilityFocusedUIElementChangedNotification;                
             break;
+        case AXAutocorrectionOccured:
+#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+            macNotification = @"AXAutocorrectionOccurred";
+            break;
+#else
+            return;
+#endif
         case AXFocusedUIElementChanged:
             macNotification = NSAccessibilityFocusedUIElementChangedNotification;

trunk/Source/WebCore/editing/Editor.cpp

@@ -2386 +2386 @@
 
                 bool useSpellingCorrectionCommand = false;
-#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+#if SUPPORT_AUTOCORRECTION_PANEL
                 if (result->type == TextCheckingTypeCorrection)
                     useSpellingCorrectionCommand = true;
@@ -2395 +2395 @@
                     m_frame->selection()->setSelection(selectionToReplace);
                     replaceSelectionWithText(result->replacement, false, false);
+                }
+
+                if (AXObjectCache::accessibilityEnabled()) {
+                    if (Element* root = m_frame->selection()->selection().rootEditableElement())
+                        m_frame->document()->axObjectCache()->postNotification(root->renderer(), AXObjectCache::AXAutocorrectionOccured, true);
                 }