Changeset 83053 in webkit


Ignore:
Timestamp:
Apr 6, 2011 8:41:18 AM (13 years ago)
Author:
podivilov@chromium.org
Message:

2011-04-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83045.
​http://trac.webkit.org/changeset/83045
​https://bugs.webkit.org/show_bug.cgi?id=57953

Broke win layout tests (Requested by podivilov on #webkit).

  • inspector/debugger/script-formatter-expected.txt: Removed.
  • inspector/debugger/script-formatter.html: Removed.
  • platform/chromium/test_expectations.txt:

2011-04-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r83045.
​http://trac.webkit.org/changeset/83045
​https://bugs.webkit.org/show_bug.cgi?id=57953

Broke win layout tests (Requested by podivilov on #webkit).

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
Location:
trunk
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83046 r83053  
     12011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r83045.
     4        http://trac.webkit.org/changeset/83045
     5        https://bugs.webkit.org/show_bug.cgi?id=57953
     6
     7        Broke win layout tests (Requested by podivilov on #webkit).
     8
     9        * inspector/debugger/script-formatter-expected.txt: Removed.
     10        * inspector/debugger/script-formatter.html: Removed.
     11        * platform/chromium/test_expectations.txt:
     12
    1132011-04-06  Andras Becsi  <abecsi@webkit.org>
    214

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r83045 r83053  
    162162WONTFIX SKIP : http/tests/eventsource/workers = PASS TIMEOUT FAIL
    163163WONTFIX SKIP : http/tests/websocket/tests/workers/ = PASS TIMEOUT FAIL
    164 WONTFIX SKIP : inspector/debugger/script-formatter.html = PASS TIMEOUT FAIL
    165164
    166165// Page Cache - based tests. Chromium disables page cache because the WebKit page cache keeps previously

  • trunk/Source/WebCore/ChangeLog

    r83052 r83053  
     12011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r83045.
     4        http://trac.webkit.org/changeset/83045
     5        https://bugs.webkit.org/show_bug.cgi?id=57953
     6
     7        Broke win layout tests (Requested by podivilov on #webkit).
     8
     9        * GNUmakefile.am:
     10        * inspector/front-end/DebuggerPresentationModel.js:
     11        (WebInspector.DebuggerPresentationModel.prototype._addScript):
     12        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
     13
    1142011-04-06  Ryosuke Niwa  <rniwa@webkit.org>
    215

  • trunk/Source/WebCore/GNUmakefile.am

    r83045 r83053  
    53165316        DerivedSources/WebCore/InspectorBackendStub.js \
    53175317        $(shell ls $(WebCore)/inspector/front-end/*.js) \
    5318         $(shell ls $(WebCore)/inspector/front-end/UglifyJS/*.js) \
    53195318        $(shell ls $(WebCore)/inspector/front-end/*.html) \
    53205319        $(shell ls $(WebCore)/inspector/front-end/*.css)
    … …  
    53305329${GENSOURCES_INSPECTOR}/inspector.html: $(WebCore)/inspector/front-end/*.html \
    53315330                $(WebCore)/inspector/front-end/*.js \
    5332                 $(WebCore)/inspector/front-end/UglifyJS/*.js \
    53335331                $(WebCore)/inspector/front-end/*.css \
    53345332                $(WebCore)/inspector/front-end/Images/* \

  • trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

    r83045 r83053  
    106106            sourceFile = new WebInspector.SourceFile(sourceFileId, script, contentChanged.bind(this));
    107107        else
    108             sourceFile = new WebInspector.FormattedSourceFile(sourceFileId, script, contentChanged.bind(this), this._formatter());
     108            sourceFile = new WebInspector.FormattedSourceFile(sourceFileId, script, contentChanged.bind(this), this._formatter);
    109109        this._sourceFiles[sourceFileId] = sourceFile;
    110110        this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.SourceFileAdded, sourceFile);
    … …  
    186186    {
    187187        this._formatSourceFiles = !this._formatSourceFiles;
     188        if (this._formatSourceFiles && !this._formatter)
     189            this._formatter = new WebInspector.ScriptFormatter();
    188190
    189191        var messages = this._messages;
    … …  
    203205        if (WebInspector.debuggerModel.callFrames)
    204206            this._debuggerPaused();
    205     },
    206 
    207     _formatter: function()
    208     {
    209         if (!this._scriptFormatter)
    210             this._scriptFormatter = new WebInspector.ScriptFormatter();
    211         return this._scriptFormatter;
    212207    },
    213208
Note: See TracChangeset for help on using the changeset viewer.