Changeset 83076 in webkit

Timestamp:

Apr 6, 2011 11:34:11 AM (13 years ago)

Author:

rniwa@webkit.org

Message:

2011-04-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

Bundle lineLeftOffset and lineRightOffset as a class
​https://bugs.webkit.org/show_bug.cgi?id=57851

Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
and only the difference is used to compute the width.

• rendering/RenderBlock.h:
• rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers. (WebCore::LineOffsets::LineOffsets): Added. (WebCore::LineOffsets::width): Added. (WebCore::LineOffsets::setLeft): Added. (WebCore::LineOffsets::setRight): Added. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine. (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlock.h (modified) (3 diffs)
• rendering/RenderBlockLineLayout.cpp (modified) (7 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Bundle lineLeftOffset and lineRightOffset as a class
+        https://bugs.webkit.org/show_bug.cgi?id=57851
+
+        Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
+        The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
+        and only the difference is used to compute the width.
+
+        * rendering/RenderBlock.h:
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers.
+        (WebCore::LineOffsets::LineOffsets): Added.
+        (WebCore::LineOffsets::width): Added.
+        (WebCore::LineOffsets::setLeft): Added.
+        (WebCore::LineOffsets::setRight): Added.
+        (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
+        (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.
+
 2011-04-06  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlock.h

@@ -37 +37 @@
 class LayoutStateMaintainer;
 class LazyLineBreakIterator;
+class LineOffsets;
 class RenderInline;
 
@@ -494 +495 @@
 
     void skipTrailingWhitespace(InlineIterator&, bool isLineEmpty, bool previousLineBrokeCleanly);
-    void skipLeadingWhitespace(InlineBidiResolver&, bool firstLine, bool isLineEmpty, bool previousLineBrokeCleanly, FloatingObject* lastFloatFromPreviousLine, int& lineLeftOffset, int& lineRightOffset);
+    void skipLeadingWhitespace(InlineBidiResolver&, bool firstLine, bool isLineEmpty, bool previousLineBrokeCleanly, FloatingObject* lastFloatFromPreviousLine, LineOffsets&);
     void fitBelowFloats(float widthToFit, float totalOverhangWidth, bool firstLine, float& availableWidth);
     typedef std::pair<RenderText*, LazyLineBreakIterator> LineBreakIteratorInfo;
@@ -509 +510 @@
     // Positions new floats and also adjust all floats encountered on the line if any of them
     // have to move to the next page/column.
-    bool positionNewFloatOnLine(FloatingObject* newFloat, FloatingObject* lastFloatFromPreviousLine, bool firstLine, int& lineLeftOffset, int& lineRightOffset);
+    bool positionNewFloatOnLine(FloatingObject* newFloat, FloatingObject* lastFloatFromPreviousLine, bool firstLine, LineOffsets&);
 
     // End of functions defined in RenderBlockLineLayout.cpp.

trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -1457 +1457 @@
 
 void RenderBlock::skipLeadingWhitespace(InlineBidiResolver& resolver, bool firstLine, bool isLineEmpty, bool previousLineBrokeCleanly,
-                                       FloatingObject* lastFloatFromPreviousLine, int& lineLeftOffset, int& lineRightOffset)
+    FloatingObject* lastFloatFromPreviousLine, LineOffsets& lineOffsets)
 {
     while (!resolver.position().atEnd() && !requiresLineBox(resolver.position(), isLineEmpty, previousLineBrokeCleanly)) {
         RenderObject* object = resolver.position().m_obj;
         if (object->isFloating())
-            positionNewFloatOnLine(insertFloatingObject(toRenderBox(object)), lastFloatFromPreviousLine, firstLine, lineLeftOffset, lineRightOffset);
+            positionNewFloatOnLine(insertFloatingObject(toRenderBox(object)), lastFloatFromPreviousLine, firstLine, lineOffsets);
         else if (object->isPositioned())
             setStaticPositions(this, toRenderBox(object));
@@ -1563 +1563 @@
 }
 
+class LineOffsets {
+public:
+    LineOffsets(int leftOffset, int rightOffset)
+    : m_left(leftOffset)
+    , m_right(rightOffset)
+    {
+    }
+    int width() const { return max(0, m_right - m_left); }
+    void setLeft(int left) { m_left = left; }
+    void setRight(int right) { m_right = right; }
+private:
+    int m_left;
+    int m_right;
+};
+
 InlineIterator RenderBlock::findNextLineBreak(InlineBidiResolver& resolver, bool firstLine, bool& isLineEmpty, LineBreakIteratorInfo& lineBreakIteratorInfo, bool& previousLineBrokeCleanly, 
                                               bool& hyphenated, EClear* clear, FloatingObject* lastFloatFromPreviousLine, Vector<RenderBox*>& positionedBoxes)
@@ -1572 +1587 @@
     
     int blockOffset = logicalHeight();
-    int lineLeftOffset = logicalLeftOffsetForLine(blockOffset, firstLine);
-    int lineRightOffset = logicalRightOffsetForLine(blockOffset, firstLine);
-    
-    skipLeadingWhitespace(resolver, firstLine, isLineEmpty, previousLineBrokeCleanly, lastFloatFromPreviousLine, lineLeftOffset, lineRightOffset);
-
-    float width = max(0, lineRightOffset - lineLeftOffset);
+    LineOffsets lineOffsets(logicalLeftOffsetForLine(blockOffset, firstLine), logicalRightOffsetForLine(blockOffset, firstLine));
+
+    skipLeadingWhitespace(resolver, firstLine, isLineEmpty, previousLineBrokeCleanly, lastFloatFromPreviousLine, lineOffsets);
+
+    float width = lineOffsets.width();
     float w = 0;
     float tmpW = 0;
@@ -1671 +1685 @@
                 // it after moving to next line (in newLine() func)
                 if (floatsFitOnLine && logicalWidthForFloat(f) + w + tmpW <= width) {
-                    positionNewFloatOnLine(f, lastFloatFromPreviousLine, firstLine, lineLeftOffset, lineRightOffset);
-                    width = max(0, lineRightOffset - lineLeftOffset) + totalOverhangWidth;
+                    positionNewFloatOnLine(f, lastFloatFromPreviousLine, firstLine, lineOffsets);
+                    width = lineOffsets.width() + totalOverhangWidth;
                     if (lBreak.m_obj == o) {
                         ASSERT(!lBreak.m_pos);
@@ -2258 +2272 @@
 }
 
-bool RenderBlock::positionNewFloatOnLine(FloatingObject* newFloat, FloatingObject* lastFloatFromPreviousLine, bool firstLine, int& lineLeftOffset, int& lineRightOffset)
+bool RenderBlock::positionNewFloatOnLine(FloatingObject* newFloat, FloatingObject* lastFloatFromPreviousLine, bool firstLine, LineOffsets& lineOffsets)
 {
     bool didPosition = positionNewFloats();
@@ -2267 +2281 @@
     if (blockOffset >= logicalTopForFloat(newFloat) && blockOffset < logicalBottomForFloat(newFloat)) {
         if (newFloat->type() == FloatingObject::FloatLeft)
-            lineLeftOffset = logicalRightForFloat(newFloat);
+            lineOffsets.setLeft(logicalRightForFloat(newFloat));
         else
-            lineRightOffset = logicalLeftForFloat(newFloat);
+            lineOffsets.setRight(logicalLeftForFloat(newFloat));
     }
 
@@ -2305 +2319 @@
 
     setLogicalHeight(blockOffset + paginationStrut);
-    lineLeftOffset = logicalLeftOffsetForLine(logicalHeight(), firstLine);
-    lineRightOffset = logicalRightOffsetForLine(logicalHeight(), firstLine);
+    lineOffsets.setLeft(logicalLeftOffsetForLine(logicalHeight(), firstLine));
+    lineOffsets.setRight(logicalRightOffsetForLine(logicalHeight(), firstLine));
 
     return didPosition;