Changeset 83175 in webkit


Ignore:
Timestamp:
Apr 7, 2011 8:42:53 AM (13 years ago)
Author:
yurys@chromium.org
Message:

2011-04-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages names should adhere to the common naming style
https://bugs.webkit.org/show_bug.cgi?id=58042

  • inspector/protocol/console-agent-expected.txt:

2011-04-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console messages names should adhere to the common naming style
https://bugs.webkit.org/show_bug.cgi?id=58042

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r83173 r83175  
     12011-04-07  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: console messages names should adhere to the common naming style
     6        https://bugs.webkit.org/show_bug.cgi?id=58042
     7
     8        * inspector/protocol/console-agent-expected.txt:
     9
    1102011-04-07  Philippe Normand  <pnormand@igalia.com>
    211
  • trunk/LayoutTests/inspector/protocol/console-agent-expected.txt

    r83171 r83175  
    5050}
    5151
    52 event ConsoleAgent.consoleMessage
     52event ConsoleAgent.messageAdded
    5353{
    54     method : "Console.consoleMessage"
     54    method : "Console.messageAdded"
    5555    params : {
    5656        messageObj : {
     
    7373}
    7474
    75 event ConsoleAgent.consoleMessageRepeatCountUpdated
     75event ConsoleAgent.messageRepeatCountUpdated
    7676{
    77     method : "Console.consoleMessageRepeatCountUpdated"
     77    method : "Console.messageRepeatCountUpdated"
    7878    params : {
    7979        count : 2
     
    101101}
    102102
    103 event ConsoleAgent.consoleMessagesCleared
     103event ConsoleAgent.messagesCleared
    104104{
    105     method : "Console.consoleMessagesCleared"
     105    method : "Console.messagesCleared"
    106106}
    107107
     
    178178    setMonitoringXHREnabled : "checked"
    179179    addInspectedNode : "checked"
    180     consoleMessage : "checked"
    181     consoleMessageRepeatCountUpdated : "checked"
    182     consoleMessagesCleared : "checked"
     180    messageAdded : "checked"
     181    messageRepeatCountUpdated : "checked"
     182    messagesCleared : "checked"
    183183}
    184184
  • trunk/Source/WebCore/ChangeLog

    r83171 r83175  
     12011-04-07  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: console messages names should adhere to the common naming style
     6        https://bugs.webkit.org/show_bug.cgi?id=58042
     7
     8        * inspector/ConsoleMessage.cpp:
     9        (WebCore::ConsoleMessage::addToFrontend):
     10        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
     11        * inspector/Inspector.json:
     12        * inspector/InspectorConsoleAgent.cpp:
     13        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
     14        * inspector/front-end/ConsoleView.js:
     15        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
     16        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
     17        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared):
     18        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
     19
    1202011-04-06  Ilya Tikhonovsky  <loislo@chromium.org>
    221
  • trunk/Source/WebCore/inspector/ConsoleMessage.cpp

    r81650 r83175  
    116116    if (m_callStack)
    117117        jsonObj->setArray("stackTrace", m_callStack->buildInspectorArray());
    118     frontend->consoleMessage(jsonObj);
     118    frontend->messageAdded(jsonObj);
    119119}
    120120
    121121void ConsoleMessage::updateRepeatCountInConsole(InspectorFrontend::Console* frontend)
    122122{
    123     frontend->consoleMessageRepeatCountUpdated(m_repeatCount);
     123    frontend->messageRepeatCountUpdated(m_repeatCount);
    124124}
    125125
  • trunk/Source/WebCore/inspector/Inspector.json

    r83164 r83175  
    219219        "events": [
    220220            {
    221                 "name": "consoleMessage",
     221                "name": "messageAdded",
    222222                "parameters": [
    223223                    { "name": "messageObj", "$ref": "ConsoleMessage" }
     
    225225            },
    226226            {
    227                 "name": "consoleMessageRepeatCountUpdated",
     227                "name": "messageRepeatCountUpdated",
    228228                "parameters": [
    229229                    { "name": "count", "type": "integer" }
     
    231231            },
    232232            {
    233                 "name": "consoleMessagesCleared"
     233                "name": "messagesCleared"
    234234            }
    235235        ]
  • trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp

    r81650 r83175  
    104104    m_inspectorDOMAgent->releaseDanglingNodes();
    105105    if (m_frontend)
    106         m_frontend->consoleMessagesCleared();
     106        m_frontend->messagesCleared();
    107107}
    108108
  • trunk/Source/WebCore/inspector/front-end/ConsoleView.js

    r82609 r83175  
    106106        var console = this;
    107107        var dispatcher = {
    108             consoleMessage: function(payload)
     108            messageAdded: function(payload)
    109109            {
    110110                var consoleMessage = new WebInspector.ConsoleMessage(
     
    122122            },
    123123
    124             consoleMessageRepeatCountUpdated: function(count)
     124            messageRepeatCountUpdated: function(count)
    125125            {
    126126                var msg = console.previousMessage;
     
    141141            },
    142142
    143             consoleMessagesCleared: function()
     143            messagesCleared: function()
    144144            {
    145145                console.clearMessages();
Note: See TracChangeset for help on using the changeset viewer.