Changeset 83225 in webkit

Timestamp:

Apr 7, 2011 4:03:43 PM (13 years ago)

Author:

eric@webkit.org

Message:

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This adds support for a new --port argument and plumbs through
the necessary paths to allow generating for a port other than Mac.

• Source/gyp/configure:

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This does not produce a buildable JavaScriptCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.

• gyp/gtk.gyp: Added.

2011-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add stub support for generating Gtk build system from gyp
​https://bugs.webkit.org/show_bug.cgi?id=58086

This does not produce a buildable WebCore, but it
does allow running gyp/configure --port=gtk and having
it generate a gtk.Makefile which we can use for testing
the rest of the plumbing.

• gyp/gtk.gyp: Added.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/gyp/gtk.gyp (added)
• Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/gyp/gtk.gyp (added)
• Source/gyp/configure (modified) (5 diffs)

trunk/ChangeLog

@@ +1 @@
+2011-04-07  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Add stub support for generating Gtk build system from gyp
+        https://bugs.webkit.org/show_bug.cgi?id=58086
+
+        This adds support for a new --port argument and plumbs through
+        the necessary paths to allow generating for a port other than Mac.
+
+        * Source/gyp/configure:
+
 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-04-07  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Add stub support for generating Gtk build system from gyp
+        https://bugs.webkit.org/show_bug.cgi?id=58086
+
+        This does not produce a buildable JavaScriptCore, but it
+        does allow running gyp/configure --port=gtk and having
+        it generate a gtk.Makefile which we can use for testing
+        the rest of the plumbing.
+
+        * gyp/gtk.gyp: Added.
+
 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-07  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Add stub support for generating Gtk build system from gyp
+        https://bugs.webkit.org/show_bug.cgi?id=58086
+
+        This does not produce a buildable WebCore, but it
+        does allow running gyp/configure --port=gtk and having
+        it generate a gtk.Makefile which we can use for testing
+        the rest of the plumbing.
+
+        * gyp/gtk.gyp: Added.
+
 2011-04-07  David Hyatt  <hyatt@apple.com>
 

trunk/Source/gyp/configure

@@ -41 +41 @@
     return os.path.join('ThirdParty', 'gyp', 'gyp')
 
+
 class Project:
     def __init__(self, name):
@@ -48 +49 @@
         return self._name
 
-    def inputs(self):
+    def _gyp_directory(self):
+        return os.path.join(self._name, 'gyp')
+
+    def _gyp_file_for_port(self, port):
+        # Gyp uses the gyp file name as the XCode proj file name, so for now "apple-mac" must be ProjectName.gyp
+        if port == "mac":
+            return '%s.gyp' % self._name
+        return "%s.gyp" % port
+
+    def inputs(self, port):
         return [
-            os.path.join(self._name, 'gyp', self._name + '.gyp'),
+            os.path.join(self._gyp_directory(), self._gyp_file_for_port(port)),
             os.path.join(self._name, self._name + '.gypi'),
             os.path.join('gyp', 'common.gypi'),
         ]
 
-    def output(self):
-        return os.path.join(self._name, 'gyp', self._name + '.xcodeproj', 'project.pbxproj')
+    def _output_for_port(self, port):
+        format = format_for_port(port)
+        return {
+            'filelist': '%s.am' % port,
+            'xcode': os.path.join(self._name + '.xcodeproj', 'project.pbxproj'),
+        }[format]
 
-    def should_generate(self):
-        if not os.path.exists(self.output()):
+    def output(self, port):
+        return os.path.join(self._gyp_directory(), self._output_for_port(port))
+
+    def should_generate(self, port):
+        if not os.path.exists(self.output(port)):
             return True
-        return os.path.getmtime(self.output()) < self._newest(self.inputs())
+        return os.path.getmtime(self.output(port)) < self._newest(self.inputs(port))
 
-    def generate(self):
-        subprocess.call([
+    def _extra_args_for_format(self, format):
+        if format == "xcode":
+            return ['-G', 'xcode_list_excluded_files=0']
+        return []
+
+    def generate(self, port):
+        args = [
             gyp(),
-            self.inputs()[0],
-            '-G',
-            'xcode_list_excluded_files=0',
+            self.inputs(port)[0],
             '--depth=.',
-        ])
+        ]
+        format = format_for_port(port)
+        args.append('--format=%s' % format)
+        args += self._extra_args_for_format(format)
+
+        subprocess.call(args)
         # GYP doesn't always touch the output file, but we want to touch the
         # file so that we don't keep trying to regenerate it.
-        os.utime(self.output(), None)
+        os.utime(self.output(port), None)
 
     @staticmethod
     def _newest(paths):
         return max([os.path.getmtime(path) for path in paths])
+
+
+def format_for_port(port):
+    return {
+        'mac': 'xcode',
+        'gtk': 'filelist',
+        'win': 'msvs',
+    }[port] # Valid port is required.
+
 
 PROJECTS = [
@@ -84 +118 @@
 ]
 
-def projects_to_generate():
-    should_generate = [project for project in PROJECTS if project.should_generate()]
+def projects_to_generate(port):
+    should_generate = [project for project in PROJECTS if project.should_generate(port)]
     already_generated = [project.name() for project in set(PROJECTS) - set(should_generate)]
 
@@ -94 +128 @@
     return should_generate
 
+
 def main():
     chdir_to_source()
 
     parser = OptionParser()
-    # FIXME: The user should be able to pass which port on the command line.
+    parser.add_option("--port", dest="port", action="store", default="mac", # Default to Mac for now
+                      help="Which port to generate for.")
     parser.add_option("--regenerate-projects", dest="regenerate_projects",
                       default=False, action="store_true",
@@ -106 +142 @@
     projects = PROJECTS
     if not options.regenerate_projects:
-        projects = projects_to_generate()
+        projects = projects_to_generate(options.port)
 
     for project in projects:
         print "Generating %s." % project.name()
-        project.generate()
+        project.generate(options.port)
+
 
 if __name__ == "__main__":