Changeset 83242 in webkit

Timestamp:

Apr 7, 2011 8:09:15 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-07 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

clearIfComposited call is really slow
​https://bugs.webkit.org/show_bug.cgi?id=57999

Move getContextAttributes call after the if, so it isn't called nearly as often.

No new tests.

• html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::clearIfComposited):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLRenderingContext.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-07  John Bauman  <jbauman@chromium.org>
+
+        Reviewed by Kenneth Russell.
+
+        clearIfComposited call is really slow
+        https://bugs.webkit.org/show_bug.cgi?id=57999
+
+        Move getContextAttributes call after the if, so it isn't called nearly as often.
+
+        No new tests.
+
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore::WebGLRenderingContext::clearIfComposited):
+
 2011-04-07  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

@@ -503 +503 @@
         return false;
 
-    RefPtr<WebGLContextAttributes> contextAttributes = getContextAttributes();
-
     if (!m_context->layerComposited() || m_layerCleared
         || m_attributes.preserveDrawingBuffer || m_framebufferBinding)
         return false;
+
+    RefPtr<WebGLContextAttributes> contextAttributes = getContextAttributes();
 
     // Determine if it's possible to combine the clear the user asked for and this clear.