Changeset 83272 in webkit

Timestamp:

Apr 8, 2011 2:26:02 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-08 Dominic Cooney <​dominicc@google.com>

Reviewed by Kent Tamura.

layoutTestController.shadowRoot should return undefined if its
argument is not an element.
​https://bugs.webkit.org/show_bug.cgi?id=58119

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):

Location:

trunk/Source/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/DumpRenderTreeSupportGtk.cpp (modified) (1 diff)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-04-08  Dominic Cooney  <dominicc@google.com>
+
+        Reviewed by Kent Tamura.
+
+        layoutTestController.shadowRoot should return undefined if its
+        argument is not an element.
+        https://bugs.webkit.org/show_bug.cgi?id=58119
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (DumpRenderTreeSupportGtk::shadowRoot):
+
 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
 

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

@@ -644 +644 @@
     Element* element = toElement(toJS(exec, value));
     if (!element)
-      return JSValueMakeNull(context);
+        return JSValueMakeUndefined(context);
 
     return toRef(exec, toJS(exec, element->shadowRoot()));