Changeset 83373 in webkit

Timestamp:

Apr 8, 2011 8:05:18 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-08 David Humphrey <​david.humphrey@senecac.on.ca>

Reviewed by Eric Carlson.

Fix call order of media element muted and play(), such that setting muted before play() works.
​https://bugs.webkit.org/show_bug.cgi?id=57673
​https://code.google.com/p/chromium/issues/detail?id=70777

Manual test added: manual-tests/media-muted.html

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState):
• manual-tests/media-muted.html: Added.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)
• manual-tests/media-muted.html (added)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-08  David Humphrey  <david.humphrey@senecac.on.ca>
+
+        Reviewed by Eric Carlson.
+
+        Fix call order of media element muted and play(), such that setting muted before play() works.
+        https://bugs.webkit.org/show_bug.cgi?id=57673
+        https://code.google.com/p/chromium/issues/detail?id=70777
+
+        Manual test added: manual-tests/media-muted.html
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::updatePlayState):
+        * manual-tests/media-muted.html: Added.
+
 2011-04-08  Nat Duca  <nduca@chromium.org>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -2138 +2138 @@
                 enterFullscreen();
 
-            // Set rate before calling play in case the rate was set before the media engine was setup.
-            // The media engine should just stash the rate since it isn't already playing.
+            // Set rate, muted before calling play in case they were set before the media engine was setup.
+            // The media engine should just stash the rate and muted values since it isn't already playing.
             m_player->setRate(m_playbackRate);
+            m_player->setMuted(m_muted);
+
             m_player->play();
         }