Changeset 83376 in webkit

Timestamp:

Apr 9, 2011 1:31:00 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-09 Jon Lee <​jonlee@apple.com>

Reviewed by Beth Dakin.

Overlay scrollbar flashes in scrollable <textarea> with each keystroke (58180)
​https://bugs.webkit.org/show_bug.cgi?id=58180
<rdar://problem/9047984>

• platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::immediateScrollToPoint): Check that there is a change before submitting (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/ScrollAnimatorMac.mm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-09  Jon Lee  <jonlee@apple.com>
+
+        Reviewed by Beth Dakin.
+
+        Overlay scrollbar flashes in scrollable <textarea> with each keystroke (58180)
+        https://bugs.webkit.org/show_bug.cgi?id=58180
+        <rdar://problem/9047984>
+
+        * platform/mac/ScrollAnimatorMac.mm:
+        (WebCore::ScrollAnimatorMac::immediateScrollToPoint): Check that there is a change before submitting
+        (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
+        (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
+
 2011-04-09  Sreeram Ramachandran  <sreeram@google.com>
 

trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm

@@ -581 +581 @@
     FloatPoint adjustedPosition = adjustScrollPositionIfNecessary(newPosition);
  
+    if (adjustedPosition.x() == m_currentPosX && adjustedPosition.y() == m_currentPosY)
+        return;
+    
     m_currentPosX = adjustedPosition.x();
     m_currentPosY = adjustedPosition.y();
@@ -588 +591 @@
 void ScrollAnimatorMac::immediateScrollByDeltaX(float deltaX)
 {
-    m_currentPosX = adjustScrollXPositionIfNecessary(m_currentPosX + deltaX);
+    float newPosX = adjustScrollXPositionIfNecessary(m_currentPosX + deltaX);
+    
+    if (newPosX == m_currentPosX)
+        return;
+    
+    m_currentPosX = newPosX;
     notityPositionChanged();
 }
@@ -594 +602 @@
 void ScrollAnimatorMac::immediateScrollByDeltaY(float deltaY)
 {
-    m_currentPosY = adjustScrollYPositionIfNecessary(m_currentPosY + deltaY);
+    float newPosY = adjustScrollYPositionIfNecessary(m_currentPosY + deltaY);
+    
+    if (newPosY == m_currentPosY)
+        return;
+    
+    m_currentPosY = newPosY;
     notityPositionChanged();
 }