Changeset 83465 in webkit


Ignore:
Timestamp:
Apr 11, 2011 11:54:47 AM (13 years ago)
Author:
mario@webkit.org
Message:

2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
https://bugs.webkit.org/show_bug.cgi?id=57826

Skipped aria-tables.html and table-cells.html layout tests.

Some changes were also made inside the aria-tables.html layout
test, in order to allow unskipping it in GTK while still keeping
it working in other platforms, without needing platform specific
tests, just different expected files.

  • accessibility/aria-tables.html: Changed the layout test so it just prints role names instead of comparing their actual values with the expected ones in one specific platform (Mac)
  • platform/gtk/Skipped: Unskipped aria-tables.html and table-cells.html.
  • platform/gtk/accessibility/aria-tables-expected.txt: Added new expectations for the GTK port.
  • platform/gtk/accessibility/table-cells-expected.txt: Ditto.
  • platform/mac-leopard/Skipped: Skipping aria-tables.html in mac-leopard, as I don't know what the expected output would be in this case, and since the expected file was invalid anyway.
  • platform/mac/accessibility/aria-tables-expected.txt: Updated to check role names, after the changes done in the layout test.

2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
https://bugs.webkit.org/show_bug.cgi?id=57826

Implement missing feature in GTK's DRT.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::cellForColumnAndRow): Implemented, by relying on the analogous function from the AtkTable interface.
Location:
trunk
Files:
1 added
7 edited
1 copied

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r83455 r83465  
     12011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
     6        https://bugs.webkit.org/show_bug.cgi?id=57826
     7
     8        Skipped aria-tables.html and table-cells.html layout tests.
     9
     10        Some changes were also made inside the aria-tables.html layout
     11        test, in order to allow unskipping it in GTK while still keeping
     12        it working in other platforms, without needing platform specific
     13        tests, just different expected files.
     14
     15        * accessibility/aria-tables.html: Changed the layout test so it
     16        just prints role names instead of comparing their actual values
     17        with the expected ones in one specific platform (Mac)
     18
     19        * platform/gtk/Skipped: Unskipped aria-tables.html and table-cells.html.
     20        * platform/gtk/accessibility/aria-tables-expected.txt: Added new
     21        expectations for the GTK port.
     22        * platform/gtk/accessibility/table-cells-expected.txt: Ditto.
     23
     24        * platform/mac-leopard/Skipped: Skipping aria-tables.html in
     25        mac-leopard, as I don't know what the expected output would be in
     26        this case, and since the expected file was invalid anyway.
     27
     28        * platform/mac/accessibility/aria-tables-expected.txt: Updated to
     29        check role names, after the changes done in the layout test.
     30
    1312011-04-11  Jian Li  <jianli@chromium.org>
    232
  • trunk/LayoutTests/accessibility/aria-tables.html

    r43669 r83465  
    5656            var failed = 0;
    5757            <!-- make sure they are tables -->
    58             if (table1.allAttributes().indexOf("AXRole: AXTable") == -1) {
    59                 failed = 1;
    60             }
    61             if (table2.allAttributes().indexOf("AXRole: AXTable") == -1) {
    62                 failed = 1;
    63             }
     58            result.innerText += table1.role + "\n";
     59            result.innerText += table2.role + "\n";
    6460
    6561            <!-- Make sure we can use cell for column and row and it works -->
    66             if (table1.cellForColumnAndRow(0,0).allAttributes().indexOf("AXRole: AXCell") == -1) {
    67                failed = 1;
    68             }
    69             if (table2.cellForColumnAndRow(0,0).allAttributes().indexOf("AXRole: AXCell") == -1) {
    70                failed = 1;
    71             }
    72 
    73             if (table1.cellForColumnAndRow(2,2).allAttributes().indexOf("AXRole: AXCell") == -1) {
    74                failed = 1;
    75             }
    76             if (table2.cellForColumnAndRow(1,1).allAttributes().indexOf("AXRole: AXCell") == -1) {
    77                failed = 1;
    78             }
     62            result.innerText += table1.cellForColumnAndRow(0,0).role + "\n";
     63            result.innerText += table2.cellForColumnAndRow(0,0).role + "\n";
     64            result.innerText += table1.cellForColumnAndRow(2,2).role + "\n";
     65            result.innerText += table2.cellForColumnAndRow(1,1).role + "\n";
    7966
    8067            <!-- now make sure we can call all the relevant methods without crashing -->
     
    9380            table1.attributesOfHeader();
    9481            table2.attributesOfHeader();
    95              
    96             if (failed) {
    97                 result.innerText += "Test failed\n";
    98             }
    99             else {
    100                  result.innerText += "Test passed\n";
    101             }
     82
     83            result.innerText += "Test passed\n";
    10284        }
    10385    </script>
  • trunk/LayoutTests/platform/gtk/Skipped

    r83450 r83465  
    328328accessibility/aria-readonly.html
    329329accessibility/aria-scrollbar-role.html
    330 accessibility/aria-tables.html
    331330accessibility/aria-tab-roles.html
    332331accessibility/aria-text-role.html
     
    357356accessibility/selection-states.html
    358357accessibility/table-attributes.html
    359 accessibility/table-cells.html
    360358accessibility/table-cell-spans.html
    361359accessibility/table-detection.html
  • trunk/LayoutTests/platform/gtk/accessibility/aria-tables-expected.txt

    r83464 r83465  
    1111cell    cell    cell
    1212cell
     13AXRole: table
     14AXRole: table
     15AXRole: table cell
     16AXRole: table cell
     17AXRole: table cell
     18AXRole: table cell
    1319Test passed
    1420
  • trunk/LayoutTests/platform/mac-leopard/Skipped

    r82990 r83465  
    2727accessibility/aria-list-and-listitem.html
    2828accessibility/aria-hidden-with-elements.html
     29accessibility/aria-tables.html
    2930platform/mac/accessibility/aria-treegrid.html
    3031platform/mac/accessibility/inherited-presentational-lists.html
  • trunk/LayoutTests/platform/mac/accessibility/aria-tables-expected.txt

    r43669 r83465  
    1111cell    cell    cell
    1212cell
     13AXRole: AXTable
     14AXRole: AXTable
     15AXRole: AXCell
     16AXRole: AXCell
     17AXRole: AXCell
     18AXRole: AXCell
    1319Test passed
    1420
  • trunk/Tools/ChangeLog

    r83463 r83465  
     12011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        Reviewed by Chris Fleizach.
     4
     5        [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
     6        https://bugs.webkit.org/show_bug.cgi?id=57826
     7
     8        Implement missing feature in GTK's DRT.
     9
     10        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
     11        (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
     12        relying on the analogous function from the AtkTable interface.
     13
    1142011-04-05  Timothy Hatcher  <timothy@apple.com>
    215
  • trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

    r83271 r83465  
    532532AccessibilityUIElement AccessibilityUIElement::cellForColumnAndRow(unsigned column, unsigned row)
    533533{
    534     // FIXME: implement
    535     return 0;
     534    if (!m_element)
     535        return 0;
     536
     537    ASSERT(ATK_IS_TABLE(m_element));
     538
     539    AtkObject* foundCell = atk_table_ref_at(ATK_TABLE(m_element), row, column);
     540    return foundCell ? AccessibilityUIElement(foundCell) : 0;
    536541}
    537542
Note: See TracChangeset for help on using the changeset viewer.