Changeset 83477 in webkit

Timestamp:

Apr 11, 2011 12:31:50 PM (13 years ago)

Author:

dpranke@chromium.org

Message:

2011-04-11 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Roben.

new-run-webkit-tests: fix crash when running under windows cmd.exe
​https://bugs.webkit.org/show_bug.cgi?id=58197

We would intermittently crash when running NRWT directly under
cmd.exe on windows because we were sharing the stdin file
descriptor between the python process and the http server.
cmd.exe really didn't like that, and there was no reason to
share the descriptor, so we now use a PIPE instead.

• Scripts/webkitpy/layout_tests/port/http_server.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/http_server.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-11  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Adam Roben.
+
+        new-run-webkit-tests: fix crash when running under windows cmd.exe
+        https://bugs.webkit.org/show_bug.cgi?id=58197
+
+        We would intermittently crash when running NRWT directly under
+        cmd.exe on windows because we were sharing the stdin file
+        descriptor between the python process and the http server.
+        cmd.exe really didn't like that, and there was no reason to
+        share the descriptor, so we now use a PIPE instead.
+
+        * Scripts/webkitpy/layout_tests/port/http_server.py:
+
 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server.py

@@ -215 +215 @@
         _log.debug('Starting http server, cmd="%s"' % str(start_cmd))
         # FIXME: Should use Executive.run_command
-        self._process = subprocess.Popen(start_cmd, env=env)
+        self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE)
 
         # Wait for server to start.