Changeset 83491 in webkit

Timestamp:

Apr 11, 2011 1:45:39 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-11 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

PerformanceTiming returns inconsistent values when timing is null.
​https://bugs.webkit.org/show_bug.cgi?id=58143

Made PerformanceTiming returned values consistent when there is no timing object.

• page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::domainLookupStart): (WebCore::PerformanceTiming::domainLookupEnd): (WebCore::PerformanceTiming::connectStart): (WebCore::PerformanceTiming::connectEnd): (WebCore::PerformanceTiming::requestStart): (WebCore::PerformanceTiming::responseStart): (WebCore::PerformanceTiming::domLoading):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/PerformanceTiming.cpp (modified) (7 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-11  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        PerformanceTiming returns inconsistent values when timing is null.
+        https://bugs.webkit.org/show_bug.cgi?id=58143
+
+        Made PerformanceTiming returned values consistent when there is no timing object.
+
+        * page/PerformanceTiming.cpp:
+        (WebCore::PerformanceTiming::domainLookupStart):
+        (WebCore::PerformanceTiming::domainLookupEnd):
+        (WebCore::PerformanceTiming::connectStart):
+        (WebCore::PerformanceTiming::connectEnd):
+        (WebCore::PerformanceTiming::requestStart):
+        (WebCore::PerformanceTiming::responseStart):
+        (WebCore::PerformanceTiming::domLoading):
+
 2011-04-05  Stephen White  <senorblanco@chromium.org>
 

trunk/Source/WebCore/page/PerformanceTiming.cpp

@@ -162 +162 @@
     ResourceLoadTiming* timing = resourceLoadTiming();
     if (!timing)
-        return 0;
+        return fetchStart();
 
     // This will be -1 when a DNS request is not performed.
@@ -177 +177 @@
     ResourceLoadTiming* timing = resourceLoadTiming();
     if (!timing)
-        return 0;
+        return domainLookupStart();
 
     // This will be -1 when a DNS request is not performed.
@@ -192 +192 @@
     DocumentLoader* loader = documentLoader();
     if (!loader)
-        return 0;
+        return domainLookupEnd();
 
     ResourceLoadTiming* timing = loader->response().resourceLoadTiming();
     if (!timing)
-        return 0;
+        return domainLookupEnd();
 
     // connectStart will be -1 when a network request is not made.
@@ -216 +216 @@
     DocumentLoader* loader = documentLoader();
     if (!loader)
-        return 0;
+        return connectStart();
 
     ResourceLoadTiming* timing = loader->response().resourceLoadTiming();
     if (!timing)
-        return 0;
+        return connectStart();
 
     // connectEnd will be -1 when a network request is not made.
@@ -252 +252 @@
     ResourceLoadTiming* timing = resourceLoadTiming();
     if (!timing)
-        return 0;
+        return connectEnd();
 
     ASSERT(timing->sendStart >= 0);
@@ -262 +262 @@
     ResourceLoadTiming* timing = resourceLoadTiming();
     if (!timing)
-        return 0;
+        return requestStart();
 
     // FIXME: Response start needs to be the time of the first received byte.
@@ -287 +287 @@
     const DocumentTiming* timing = documentTiming();
     if (!timing)
-        return 0;
+        return fetchStart();
 
     return toIntegerMilliseconds(timing->domLoading);