Changeset 83560 in webkit

Timestamp:

Apr 12, 2011 12:48:21 AM (13 years ago)

Author:

Philippe Normand

Message:

2011-04-11 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] warnings in media/video-set-rate-from-pause.html
​https://bugs.webkit.org/show_bug.cgi?id=58220

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::setRate): Pause the pipeline if new rate is zero, like advised in the GStreamer documentation of gst_event_new_seek().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-11  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GStreamer] warnings in media/video-set-rate-from-pause.html
+        https://bugs.webkit.org/show_bug.cgi?id=58220
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::setRate): Pause the
+        pipeline if new rate is zero, like advised in the GStreamer
+        documentation of gst_event_new_seek().
+
 2011-04-11  Vangelis Kokkevis  <vangelis@chromium.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -705 +705 @@
     m_playbackRate = rate;
     m_changingRate = true;
+
+    if (!rate) {
+        gst_element_set_state(m_playBin, GST_STATE_PAUSED);
+        return;
+    }
+
     float currentPosition = static_cast<float>(playbackPosition(m_playBin) * GST_SECOND);
     GstSeekFlags flags = (GstSeekFlags)(GST_SEEK_FLAG_FLUSH);
@@ -711 +717 @@
 
     LOG_VERBOSE(Media, "Set Rate to %f", rate);
-    if (rate >= 0) {
+    if (rate > 0) {
         // Mute the sound if the playback rate is too extreme.
         // TODO: in other cases we should perform pitch adjustments.