Changeset 83616 in webkit


Ignore:
Timestamp:
Apr 12, 2011 11:40:45 AM (13 years ago)
Author:
abarth@webkit.org
Message:

2011-04-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Review tool should work well on iPad
https://bugs.webkit.org/show_bug.cgi?id=58351

On the iPad, the toolbar ends up at some random position in the middle
of the page because of how position:fixed interacts with scrolling on
the iPad. I feel a bit dirty using a user agent detect, but I'm not
sure if there's a better way to detect whether the user agent has this
behavior.

  • code-review.js:
Location:
trunk/Websites/bugs.webkit.org
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Websites/bugs.webkit.org/ChangeLog

    r81180 r83616  
     12011-04-12  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Review tool should work well on iPad
     6        https://bugs.webkit.org/show_bug.cgi?id=58351
     7
     8        On the iPad, the toolbar ends up at some random position in the middle
     9        of the page because of how position:fixed interacts with scrolling on
     10        the iPad.  I feel a bit dirty using a user agent detect, but I'm not
     11        sure if there's a better way to detect whether the user agent has this
     12        behavior.
     13
     14        * code-review.js:
     15
    1162011-03-15  David Levin  <levin@chromium.org>
    217
  • trunk/Websites/bugs.webkit.org/code-review.js

    r79836 r83616  
    10371037
    10381038  function updateToolbarAnchorState() {
     1039    // For iPad, we always leave the toolbar at the bottom of the document
     1040    // because of the iPad's handling of position:fixed and scrolling.
     1041    if (navigator.platform.indexOf("iPad") != -1)
     1042      return;
     1043
    10391044    var toolbar = $('#toolbar');
    10401045    // Unanchor the toolbar and then see if it's bottom is below the body's bottom.
Note: See TracChangeset for help on using the changeset viewer.