Changeset 83694 in webkit


Ignore:
Timestamp:
Apr 12, 2011 9:13:33 PM (13 years ago)
Author:
vangelis@chromium.org
Message:

2011-04-12 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Adding layout test for:
​https://bugs.webkit.org/show_bug.cgi?id=58397

  • platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.checksum: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
  • platform/chromium/compositing/child-layer-3d-sorting.html: Added.
  • platform/chromium/test_expectations.txt:

2011-04-12 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Move the calculation of the layer's z coordinate to the
right spot so that it can be picked up by its sublayers.
​https://bugs.webkit.org/show_bug.cgi?id=58397

Test: platform/chromium/compositing/child-layer-3d-sorting.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83690 r83694  
     12011-04-12  Vangelis Kokkevis  <vangelis@chromium.org>
     2
     3        Reviewed by James Robinson.
     4
     5        [chromium] Adding layout test for:
     6        https://bugs.webkit.org/show_bug.cgi?id=58397
     7
     8
     9        * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.checksum: Added.
     10        * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
     11        * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
     12        * platform/chromium/compositing/child-layer-3d-sorting.html: Added.
     13        * platform/chromium/test_expectations.txt:
     14
    1152011-04-12  Kenichi Ishibashi  <bashi@chromium.org>
    216

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r83677 r83694  
    28482848// Will need windows and linux baselines
    28492849BUGWK58182 GPU : compositing/images/content-image-change.html = PASS FAIL
     2850BUGWK58398 GPU : platform/chromium/compositing/child-layer-3d-sorting.html = PASS FAIL
    28502851
    28512852// The picture does not match the video in the test.

  • trunk/Source/WebCore/ChangeLog

    r83691 r83694  
     12011-04-12  Vangelis Kokkevis  <vangelis@chromium.org>
     2
     3        Reviewed by James Robinson.
     4
     5        [chromium] Move the calculation of the layer's z coordinate to the
     6        right spot so that it can be picked up by its sublayers.
     7        https://bugs.webkit.org/show_bug.cgi?id=58397
     8
     9        Test: platform/chromium/compositing/child-layer-3d-sorting.html
     10
     11        * platform/graphics/chromium/LayerRendererChromium.cpp:
     12        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
     13
    1142011-04-12  Luiz Agostini  <luiz.agostini@openbossa.org>
    215

  • trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp

    r83552 r83694  
    744744    sublayerMatrix.translate3d(-bounds.width() * 0.5, -bounds.height() * 0.5, 0);
    745745
     746    // Compute the depth value of the center of the layer which will be used when
     747    // sorting the layers for the preserves-3d property.
     748    const TransformationMatrix& layerDrawMatrix = drawLayer->renderSurface() ? drawLayer->renderSurface()->m_drawTransform : drawLayer->drawTransform();
     749    if (drawLayer->superlayer()) {
     750        if (!drawLayer->superlayer()->preserves3D())
     751            drawLayer->setDrawDepth(drawLayer->superlayer()->drawDepth());
     752        else
     753            drawLayer->setDrawDepth(layerDrawMatrix.m43());
     754    } else
     755        drawLayer->setDrawDepth(0);
     756
    746757    LayerList& descendants = (drawLayer->renderSurface() ? drawLayer->renderSurface()->m_layerList : layerList);
    747758    descendants.append(drawLayer);
    … …  
    814825        }
    815826    }
    816 
    817     // Compute the depth value of the center of the layer which will be used when
    818     // sorting the layers for the preserves-3d property.
    819     const TransformationMatrix& layerDrawMatrix = drawLayer->renderSurface() ? drawLayer->renderSurface()->m_drawTransform : drawLayer->drawTransform();
    820     if (drawLayer->superlayer()) {
    821         if (!drawLayer->superlayer()->preserves3D())
    822             drawLayer->setDrawDepth(drawLayer->superlayer()->drawDepth());
    823         else
    824             drawLayer->setDrawDepth(layerDrawMatrix.m43());
    825     } else
    826         drawLayer->setDrawDepth(0);
    827827
    828828    // If preserves-3d then sort all the descendants by the Z coordinate of their
Note: See TracChangeset for help on using the changeset viewer.