Changeset 83804 in webkit
- Timestamp:
- Apr 13, 2011 6:47:26 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r83803 r83804 1 2011-04-13 Alexis Menard <alexis.menard@openbossa.org> 2 3 Reviewed by Dimitri Glazkov. 4 5 The timeline of the video controls is unusable if the multimedia backend returns a 6 infinite duration. 7 https://bugs.webkit.org/show_bug.cgi?id=58452 8 9 In case the underlaying media element backend returns crazy values, e.g. 10 an infinite duration for the video we need to bail out and hide the timeline 11 rather than in a broken state where you can't use it. The previous code was just 12 checking if the duration was NaN. 13 14 We can't control from JS what the backend will return as a duration for the video 15 so we can't make an test for it. 16 17 * html/shadow/MediaControlRootElement.cpp: 18 (WebCore::MediaControlRootElement::reset): 19 1 20 2011-04-13 Abhishek Arya <inferno@chromium.org> 2 21 -
trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp
r83600 r83804 288 288 289 289 float duration = m_mediaElement->duration(); 290 if ( !isnan(duration) || page->theme()->hasOwnDisabledStateHandlingFor(MediaSliderPart)) {290 if (isfinite(duration) || page->theme()->hasOwnDisabledStateHandlingFor(MediaSliderPart)) { 291 291 m_timeline->setDuration(duration); 292 292 m_timelineContainer->show();
Note: See TracChangeset
for help on using the changeset viewer.