Changeset 83847 in webkit


Ignore:
Timestamp:
Apr 14, 2011 6:22:17 AM (13 years ago)
Author:
alexis.menard@openbossa.org
Message:

2011-04-14 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r83397) [Qt] When clicking on the media elements they
grow 2 pixels.
​https://bugs.webkit.org/show_bug.cgi?id=58477

Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size.

  • css/mediaControls.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r83846 r83847  
     12011-04-14  Alexis Menard  <alexis.menard@openbossa.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        REGRESSION(r83397) [Qt] When clicking on the media elements they
     6        grow 2 pixels.
     7        https://bugs.webkit.org/show_bug.cgi?id=58477
     8
     9        Since r83397 the media controls elements are actual DOM elements.
     10        Therefore the global style-sheet applies to them. html.css defines
     11        input[type="button"]:active to be border-style: inset which means
     12        that when the buttons are active they grow by their border size.
     13
     14        * css/mediaControls.css:
     15        (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
     16        (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
     17        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
     18        (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
     19        (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
     20        (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
     21        (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
     22        (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
     23        (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
     24        (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
     25        (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
     26
    1272011-04-14  Diego Gonzalez  <diegohcg@webkit.org>
    228

  • trunk/Source/WebCore/css/mediaControls.css

    r83397 r83847  
    6161    height: 16px;
    6262    background-color: initial;
    63     border: initial;
     63    border: none !important;
    6464    color: inherit;
    6565}
    … …  
    7171    height: 16px;
    7272    background-color: initial;
    73     border: initial;
     73    border: none !important;
    7474    color: inherit;
    7575}
    … …  
    101101    padding: 0px 2px;
    102102    background-color: initial;
    103     border: initial;
     103    border: none !important;
    104104    color: inherit;
    105105    margin: initial;
    … …  
    109109    background-color: initial;
    110110    border: initial;
    111     color: inherit;
     111    border: none !important;
    112112    margin: initial;
    113113}
    … …  
    119119    height: 16px;
    120120    background-color: initial;
    121     border: initial;
     121    border: none !important;
    122122    color: inherit;
    123123}
    … …  
    129129    height: 16px;
    130130    background-color: initial;
    131     border: initial;
     131    border: none !important;
    132132    color: inherit;
    133133}
    … …  
    139139    height: 16px;
    140140    background-color: initial;
    141     border: initial;
     141    border: none !important;
    142142    color: inherit;
    143143}
    … …  
    146146    display: none;
    147147    background-color: initial;
    148     border: initial;
     148    border: none !important;
    149149    color: inherit;
    150150}
    … …  
    153153    display: none;
    154154    background-color: initial;
    155     border: initial;
     155    border: none !important;
    156156    color: inherit;
    157157}
    … …  
    163163    height: 16px;
    164164    background-color: initial;
    165     border: initial;
     165    border: none !important;
    166166    color: inherit;
    167167}
    … …  
    171171    display: none;
    172172    background-color: initial;
    173     border: initial;
     173    border: none !important;
    174174    color: inherit;
    175175}
Note: See TracChangeset for help on using the changeset viewer.