Changeset 83880 in webkit

Timestamp:

Apr 14, 2011 11:53:52 AM (13 years ago)

Author:

dpranke@chromium.org

Message:

2011-04-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Roben.

REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
​https://bugs.webkit.org/show_bug.cgi?id=58545

Remove platform-specific overrides; the default behavior should
be working everywhere now, I think.

• Scripts/webkitpy/layout_tests/port/chromium_win.py:
• Scripts/webkitpy/layout_tests/port/mac.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/chromium_win.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-14  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Adam Roben.
+
+        REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
+        https://bugs.webkit.org/show_bug.cgi?id=58545
+
+        Remove platform-specific overrides; the default behavior should
+        be working everywhere now, I think.
+
+        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+
 2011-04-14  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py

@@ -117 +117 @@
         return result
 
-    def default_worker_model(self):
-        # FIXME: should use base class method instead. See bug 55163.
-        return 'old-threads'
-
-    def default_worker_model(self):
-        if self._multiprocessing_is_available:
-            return 'processes'
-        return 'old-threads'
-
     def relative_test_filename(self, filename):
         path = filename[len(self.layout_tests_dir()) + 1:]

trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -95 +95 @@
         return child_processes
 
-    def default_worker_model(self):
-        if self._multiprocessing_is_available:
-            return 'processes'
-        return 'threads'
-
     def baseline_path(self):
         if self.version() != 'future':