Changeset 83881 in webkit


Ignore:
Timestamp:
Apr 14, 2011 11:55:31 AM (13 years ago)
Author:
eric@webkit.org
Message:

2011-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

queues.webkit.org should display when a bot last passed a patch
​https://bugs.webkit.org/show_bug.cgi?id=58546

I am suspicious that some of our commit-queue instances are never
actually passing anything.

This will let us know if those bots are never passing patches.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/templates/queuestatus.html:
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r83880 r83881  
     12011-04-14  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        queues.webkit.org should display when a bot last passed a patch
     6        https://bugs.webkit.org/show_bug.cgi?id=58546
     7
     8        I am suspicious that some of our commit-queue instances are never
     9        actually passing anything.
     10
     11        This will let us know if those bots are never passing patches.
     12
     13        * QueueStatusServer/handlers/queuestatus.py:
     14        * QueueStatusServer/index.yaml:
     15        * QueueStatusServer/templates/queuestatus.html:
     16
    1172011-04-14  Dirk Pranke  <dpranke@chromium.org>
    218

  • trunk/Tools/QueueStatusServer/handlers/queuestatus.py

    r75060 r83881  
    6464        return statuses.order("-date").fetch(15)
    6565
     66    def _fetch_last_pass(self, queue, bot_id):
     67        statuses = queuestatus.QueueStatus.all()
     68        statuses = statuses.filter("queue_name =", queue.name())
     69        if bot_id:
     70            statuses.filter("bot_id =", bot_id)
     71        statuses.filter("message =", "Pass")
     72        return statuses.order("-date").get()
     73
    6674    def _page_title(self, queue, bot_id):
    6775        title = "%s Messages" % queue.display_name()
    … …  
    7886
    7987        statuses = self._fetch_statuses(queue, bot_id)
     88        last_pass = self._fetch_last_pass(queue, bot_id)
    8089        template_values = {
    8190            "page_title": self._page_title(queue, bot_id),
    … …  
    8392            "status_groups": self._build_status_groups(statuses),
    8493            "bot_id": bot_id,
     94            "last_pass": last_pass,
    8595        }
    8696        self.response.out.write(template.render("templates/queuestatus.html", template_values))

  • trunk/Tools/QueueStatusServer/index.yaml

    r75060 r83881  
    2727  properties:
    2828  - name: bot_id
     29  - name: message
     30  - name: queue_name
     31  - name: date
     32    direction: desc
     33
     34- kind: QueueStatus
     35  properties:
     36  - name: bot_id
     37  - name: queue_name
     38  - name: date
     39    direction: desc
     40
     41- kind: QueueStatus
     42  properties:
     43  - name: message
    2944  - name: queue_name
    3045  - name: date

  • trunk/Tools/QueueStatusServer/templates/queuestatus.html

    r75060 r83881  
    77<body>
    88<h1>{{ page_title }}</h1>
     9
     10{% if last_pass %}
     11<h3>Summary</h3>
     12<div>Last Pass: {{ last_pass.date|timesince }} ago</div>
     13{% endif %}
    914
    1015<h3>Recent Status</h3>
Note: See TracChangeset for help on using the changeset viewer.