Changeset 83887 in webkit


Ignore:
Timestamp:
Apr 14, 2011 1:26:57 PM (13 years ago)
Author:
jamesr@google.com
Message:

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=58535

Remove unnecessary baselines - the behavior on these tests should
match the mac port now.

  • platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
  • platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
  • platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
  • platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
  • platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
  • platform/win/compositing/overflow/resize-painting-expected.txt: Removed.

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=58535

Change PLATFORM(MAC) guards to !PLATFORM(CHROMIUM) so they apply correctly to the windows build.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer): (WebCore::RenderLayerBacking::requiresScrollCornerLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::shouldCompositeOverflowControls):
Location:
trunk
Files:
17 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83886 r83887  
     12011-04-14  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
     6        https://bugs.webkit.org/show_bug.cgi?id=58535
     7
     8        Remove unnecessary baselines - the behavior on these tests should
     9        match the mac port now.
     10
     11        * platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
     12        * platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
     13        * platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
     14        * platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
     15        * platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
     16        * platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
     17        * platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
     18        * platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
     19        * platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
     20        * platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
     21        * platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
     22        * platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
     23        * platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
     24        * platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
     25        * platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
     26        * platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
     27        * platform/win/compositing/overflow/resize-painting-expected.txt: Removed.
     28
    1292011-04-14  Csaba Osztrogonác  <ossy@webkit.org>
    230

  • trunk/Source/WebCore/ChangeLog

    r83884 r83887  
     12011-04-14  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
     6        https://bugs.webkit.org/show_bug.cgi?id=58535
     7
     8        Change PLATFORM(MAC) guards to !PLATFORM(CHROMIUM) so they apply correctly to the windows build.
     9
     10        * rendering/RenderLayerBacking.cpp:
     11        (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
     12        (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
     13        (WebCore::RenderLayerBacking::requiresScrollCornerLayer):
     14        * rendering/RenderLayerCompositor.cpp:
     15        (WebCore::shouldCompositeOverflowControls):
     16
    1172011-04-14  Jian Li  <jianli@chromium.org>
    218

  • trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

    r83820 r83887  
    566566bool RenderLayerBacking::requiresHorizontalScrollbarLayer() const
    567567{
    568 #if PLATFORM(MAC)
     568#if !PLATFORM(CHROMIUM)
    569569    if (!m_owningLayer->hasOverlayScrollbars())
    570570        return false;
    … …  
    575575bool RenderLayerBacking::requiresVerticalScrollbarLayer() const
    576576{
    577 #if PLATFORM(MAC)
     577#if !PLATFORM(CHROMIUM)
    578578    if (!m_owningLayer->hasOverlayScrollbars())
    579579        return false;
    … …  
    584584bool RenderLayerBacking::requiresScrollCornerLayer() const
    585585{
    586 #if PLATFORM(MAC)
     586#if !PLATFORM(CHROMIUM)
    587587    if (!m_owningLayer->hasOverlayScrollbars())
    588588        return false;

  • trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

    r83820 r83887  
    14671467    if (view->platformWidget())
    14681468        return false;
    1469 #if PLATFORM(MAC)
     1469#if !PLATFORM(CHROMIUM)
    14701470    if (!view->hasOverlayScrollbars())
    14711471        return false;
Note: See TracChangeset for help on using the changeset viewer.