Changeset 83889 in webkit


Ignore:
Timestamp:
Apr 14, 2011 1:34:29 PM (13 years ago)
Author:
aestes@apple.com
Message:

2011-04-14 Andy Estes <​aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r72141): Acid3 rendering is not pixel perfect.
​https://bugs.webkit.org/show_bug.cgi?id=55734

  • fast/text/zero-font-size.html: Added.
  • platform/mac/fast/text/zero-font-size-expected.checksum: Added.
  • platform/mac/fast/text/zero-font-size-expected.png: Added.
  • platform/mac/fast/text/zero-font-size-expected.txt: Added.

2011-04-14 Andy Estes <​aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r72141): Acid3 rendering is not pixel perfect.
​https://bugs.webkit.org/show_bug.cgi?id=55734

WebCore should render text with a 0px font size at 0px regardless of
minimum font size settings. This is compatible with other browsers that
have a minimum font size preference and ensures pixel-perfect rendering
on Acid3.

Test: fast/text/zero-font-size.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): If specifiedSize is 0, return specified size regardless of zoom factor or minimum font size.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83888 r83889  
     12011-04-14  Andy Estes  <aestes@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        REGRESSION (r72141): Acid3 rendering is not pixel perfect.
     6        https://bugs.webkit.org/show_bug.cgi?id=55734
     7
     8        * fast/text/zero-font-size.html: Added.
     9        * platform/mac/fast/text/zero-font-size-expected.checksum: Added.
     10        * platform/mac/fast/text/zero-font-size-expected.png: Added.
     11        * platform/mac/fast/text/zero-font-size-expected.txt: Added.
     12
    1132011-04-14  Matthew Delaney  <mdelaney@apple.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r83888 r83889  
     12011-04-14  Andy Estes  <aestes@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        REGRESSION (r72141): Acid3 rendering is not pixel perfect.
     6        https://bugs.webkit.org/show_bug.cgi?id=55734
     7       
     8        WebCore should render text with a 0px font size at 0px regardless of
     9        minimum font size settings. This is compatible with other browsers that
     10        have a minimum font size preference and ensures pixel-perfect rendering
     11        on Acid3.
     12
     13        Test: fast/text/zero-font-size.html
     14
     15        * css/CSSStyleSelector.cpp:
     16        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): If
     17        specifiedSize is 0, return specified size regardless of zoom factor or
     18        minimum font size.
     19
    1202011-04-14  Matthew Delaney  <mdelaney@apple.com>
    221

  • trunk/Source/WebCore/css/CSSStyleSelector.cpp

    r83820 r83889  
    68026802float CSSStyleSelector::getComputedSizeFromSpecifiedSize(Document* document, RenderStyle* style, bool isAbsoluteSize, float specifiedSize, bool useSVGZoomRules)
    68036803{
     6804    // Text with a 0px font size should not be visible and therefore needs to be
     6805    // exempt from minimum font size rules. Acid3 relies on this for pixel-perfect
     6806    // rendering. This is also compatible with other browsers that have minimum
     6807    // font size settings (e.g. Firefox).
     6808    if (fabsf(specifiedSize) < std::numeric_limits<float>::epsilon())
     6809        return 0.0f;
     6810
    68046811    float zoomFactor = 1.0f;
    68056812    if (!useSVGZoomRules) {
Note: See TracChangeset for help on using the changeset viewer.