Changeset 83914 in webkit

Timestamp:

Apr 14, 2011 4:54:25 PM (13 years ago)

Author:

jamesr@google.com

Message:

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
​https://bugs.webkit.org/show_bug.cgi?id=58575

Remove expected failure lines for pixel tests that now should pass.

• platform/chromium/test_expectations.txt:

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
​https://bugs.webkit.org/show_bug.cgi?id=58575

Tell the RenderLayerCompositor to create/destroy composited layers for overflow controls on a FrameView when visibleContentsResized()
is called, not contentsResized() so that we always update layers when adding or removing scrollbars.

Covered by several chromium pixel tests.

• page/FrameView.cpp: (WebCore::FrameView::contentsResized): (WebCore::FrameView::visibleContentsResized):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/FrameView.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-14  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
+        https://bugs.webkit.org/show_bug.cgi?id=58575
+
+        Remove expected failure lines for pixel tests that now should pass.
+
+        * platform/chromium/test_expectations.txt:
+
 2011-04-14  Chris Rogers  <crogers@google.com>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3089 +3089 @@
 BUGCR75019 WIN LINUX MAC :fast/text/hyphenate-limit-before-after.html = IMAGE+TEXT
 
-// Need further investigation related to bug 57202.
-BUGJAMESR GPU : compositing/direct-image-compositing.html = IMAGE
-BUGJAMESR GPU : compositing/geometry/fixed-in-composited.html = IMAGE
-BUGJAMESR GPU : compositing/geometry/tall-page-composited.html = IMAGE
-BUGJAMESR GPU : compositing/geometry/video-fixed-scrolling.html = IMAGE
-BUGJAMESR GPU : compositing/masks/simple-composited-mask.html = IMAGE
-BUGJAMESR GPU : fast/canvas/canvas-text-alignment.html = IMAGE
-BUGJAMESR GPU MAC : fast/canvas/image-object-in-canvas.html = IMAGE
-BUGJAMESR GPU : compositing/masks/masked-ancestor.html = IMAGE
-BUGJAMESR GPU MAC : compositing/masks/multiple-masks.html = IMAGE
-BUGJAMESR GPU : compositing/layer-creation/overflow-scroll-overlap.html = TEXT
-
 // Seems to blend scrollbars very slightly differently in debug vs. release.
 BUGWK58587 DEBUG GPU LINUX : compositing/geometry/horizontal-scroll-composited.html = IMAGE

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-14  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
+        https://bugs.webkit.org/show_bug.cgi?id=58575
+
+        Tell the RenderLayerCompositor to create/destroy composited layers for overflow controls on a FrameView when visibleContentsResized()
+        is called, not contentsResized() so that we always update layers when adding or removing scrollbars.
+
+        Covered by several chromium pixel tests.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::contentsResized):
+        (WebCore::FrameView::visibleContentsResized):
+
 2011-04-07  David Levin  <levin@chromium.org>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -1513 +1513 @@
     scrollAnimator()->contentsResized();
     setNeedsLayout();
-
-#if USE(ACCELERATED_COMPOSITING)
-    if (RenderView* root = m_frame->contentRenderer()) {
-        if (root->usesCompositing())
-            root->compositor()->frameViewDidChangeSize();
-    }
-#endif
 }
 
@@ -1533 +1526 @@
     if (needsLayout())
         layout();
+
+#if USE(ACCELERATED_COMPOSITING)
+    if (RenderView* root = m_frame->contentRenderer()) {
+        if (root->usesCompositing())
+            root->compositor()->frameViewDidChangeSize();
+    }
+#endif
 }