Changeset 83919 in webkit

Timestamp:

Apr 14, 2011 5:51:05 PM (13 years ago)

Author:

andersca@apple.com

Message:

2011-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Select All context menu item doesn't work in Flash
​https://bugs.webkit.org/show_bug.cgi?id=58615
<rdar://problem/9225761>

In some cases, -[NSWindow isKeyWindow] will return false even if
a window is the key window, so we have to compare our window
against -[NSApplication keyWindow].

• UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isViewWindowActive):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/PageClientImpl.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-14  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Select All context menu item doesn't work in Flash
+        https://bugs.webkit.org/show_bug.cgi?id=58615
+        <rdar://problem/9225761>
+
+        In some cases, -[NSWindow isKeyWindow] will return false even if
+        a window is the key window, so we have to compare our window
+        against -[NSApplication keyWindow].
+
+        * UIProcess/API/mac/PageClientImpl.mm:
+        (WebKit::PageClientImpl::isViewWindowActive):
+
 2011-04-14  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm

@@ -155 +155 @@
 bool PageClientImpl::isViewWindowActive()
 {
-    return [[m_wkView window] isKeyWindow];
+    return [[m_wkView window] isKeyWindow] || [NSApp keyWindow] == [m_wkView window];
 }