Changeset 83930 in webkit


Ignore:
Timestamp:
Apr 14, 2011 7:09:01 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-14 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
​https://bugs.webkit.org/show_bug.cgi?id=57818

  • fast/forms/select-background-none.html: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.txt: Added.
  • platform/chromium-linux/fast/forms/select-background-none-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/select-background-none-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-background-none-expected.txt: Added.
  • platform/mac/fast/forms/select-background-none-expected.txt: Added.

2011-04-14 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
​https://bugs.webkit.org/show_bug.cgi?id=57818

Test: fast/forms/select-background-none.html

This fix is only for Chromium on Linux. Chromium on Mac already works fine.
But Windows has the same problem. This change doesn't include Windows part.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::paintMenuList): Change the default color to transparent.
Location:
trunk
Files:
8 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83927 r83930  
     12011-04-14  Naoki Takano  <takano.naoki@gmail.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
     6        https://bugs.webkit.org/show_bug.cgi?id=57818
     7
     8        * fast/forms/select-background-none.html: Added.
     9        * platform/chromium-mac/fast/forms/select-background-none-expected.checksum: Added.
     10        * platform/chromium-mac/fast/forms/select-background-none-expected.png: Added.
     11        * platform/chromium-mac/fast/forms/select-background-none-expected.txt: Added.
     12        * platform/chromium-linux/fast/forms/select-background-none-expected.checksum: Added.
     13        * platform/chromium-linux/fast/forms/select-background-none-expected.png: Added.
     14        * platform/chromium-linux/fast/forms/select-background-none-expected.txt: Added.
     15        * platform/mac/fast/forms/select-background-none-expected.txt: Added.
     16
    1172011-04-14  Adrienne Walker  <enne@google.com>
    218

  • trunk/Source/WebCore/ChangeLog

    r83926 r83930  
     12011-04-14  Naoki Takano  <takano.naoki@gmail.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
     6        https://bugs.webkit.org/show_bug.cgi?id=57818
     7
     8        Test: fast/forms/select-background-none.html
     9
     10        This fix is only for Chromium on Linux. Chromium on Mac already works fine.
     11        But Windows has the same problem. This change doesn't include Windows part.
     12
     13        * rendering/RenderThemeChromiumLinux.cpp:
     14        (WebCore::RenderThemeChromiumLinux::paintMenuList): Change the default color to transparent.
     15
    1162011-04-14  Luke Macpherson   <macpherson@chromium.org>
    217

  • trunk/Source/WebCore/rendering/RenderThemeChromiumLinux.cpp

    r78493 r83930  
    275275    extraParams.menuList.hasBorder = box->borderRight() || box->borderLeft() || box->borderTop() || box->borderBottom();
    276276    extraParams.menuList.hasBorderRadius = o->style()->hasBorderRadius();
    277     extraParams.menuList.backgroundColor = SkColorSetRGB(0xdd, 0xdd, 0xdd);
     277    // Fallback to transparent if the specified color object is invalid.
     278    extraParams.menuList.backgroundColor = Color::transparent;
    278279    if (o->hasBackground())
    279280        extraParams.menuList.backgroundColor = o->style()->visitedDependentColor(CSSPropertyBackgroundColor).rgb();
Note: See TracChangeset for help on using the changeset viewer.