Changeset 83939 in webkit


Ignore:
Timestamp:
Apr 14, 2011 8:43:35 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-14 Ami Fischman <​fischman@google.com>

Reviewed by Eric Carlson.

Update expectation to reflect removal of the -25px bottom margin.
​https://bugs.webkit.org/show_bug.cgi?id=58442

  • media/media-document-audio-repaint-expected.txt:

2011-04-14 Ami Fischman <​fischman@google.com>

Reviewed by Eric Carlson.

Remove unnecessary bottom margin of controls in video elements on media documents.
This makes the cases of media documents and non-media documents consistent,
and makes it possible to reason about the height of a rendered media document
(needed e.g. for sizing iframes).

This change is covered by (the currently Skipped, but soon-to-be-un-Skipped)
media/video-controls-in-media-document.html layouttest (see bug 54634 for
the un-Skipping).

​https://bugs.webkit.org/show_bug.cgi?id=58442

  • css/mediaControls.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
  • css/mediaControlsEfl.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
  • css/mediaControlsQuickTime.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83937 r83939  
     12011-04-14  Ami Fischman  <fischman@google.com>
     2
     3        Reviewed by Eric Carlson.
     4
     5        Update expectation to reflect removal of the -25px bottom margin.
     6        https://bugs.webkit.org/show_bug.cgi?id=58442
     7
     8        * media/media-document-audio-repaint-expected.txt:
     9
    1102011-04-14  James Robinson  <jamesr@chromium.org>
    211

  • trunk/LayoutTests/media/media-document-audio-repaint-expected.txt

    r79359 r83939  
    2222    layer at (40,164) size 300x1
    2323      RenderBlock (relative positioned) {DIV} at (0,0) size 300x1
    24     layer at (40,165) size 300x25
    25       RenderFlexibleBox (positioned) {DIV} at (0,1) size 300x25
     24    layer at (40,140) size 300x25
     25      RenderFlexibleBox (positioned) {DIV} at (0,-24) size 300x25
    2626        RenderButton {INPUT} at (6,3) size 18x18
    2727        RenderButton {INPUT} at (32,4) size 16x16
    … …  
    3030            RenderBlock {DIV} at (63,2) size 10x8
    3131        RenderButton {INPUT} at (277,6) size 14x12
    32     layer at (89,172) size 45x11
     32    layer at (89,147) size 45x11
    3333      RenderFlexibleBox {DIV} at (0,2) size 45x11 [color=#FFFFFF]
    3434        RenderBlock (anonymous) at (9,0) size 26x11
    3535          RenderText {#text} at (0,0) size 26x11
    3636            text run at (0,0) width 26: "00:00"
    37     layer at (270,172) size 45x11
     37    layer at (270,147) size 45x11
    3838      RenderFlexibleBox {DIV} at (181,2) size 45x11 [color=#FFFFFF]
    3939        RenderBlock (anonymous) at (7,0) size 31x11

  • trunk/Source/WebCore/ChangeLog

    r83938 r83939  
     12011-04-14  Ami Fischman  <fischman@google.com>
     2
     3        Reviewed by Eric Carlson.
     4
     5        Remove unnecessary bottom margin of controls in video elements on media documents.
     6        This makes the cases of media documents and non-media documents consistent,
     7        and makes it possible to reason about the height of a rendered media document
     8        (needed e.g. for sizing iframes).
     9
     10        This change is covered by (the currently Skipped, but soon-to-be-un-Skipped)
     11        media/video-controls-in-media-document.html layouttest (see bug 54634 for
     12        the un-Skipping).
     13
     14        https://bugs.webkit.org/show_bug.cgi?id=58442
     15
     16        * css/mediaControls.css:
     17        (video:-webkit-full-page-media::-webkit-media-controls-panel):
     18        * css/mediaControlsEfl.css:
     19        (video:-webkit-full-page-media::-webkit-media-controls-panel):
     20        * css/mediaControlsQuickTime.css:
     21        (video:-webkit-full-page-media::-webkit-media-controls-panel):
     22
    1232011-04-14  Geoffrey Garen  <ggaren@apple.com>
    224

  • trunk/Source/WebCore/css/mediaControls.css

    r83858 r83939  
    11/*
    2  * Copyright (C) 2009, 2010 Apple Inc.  All rights reserved.
     2 * Copyright (C) 2009, 2010, 2011 Apple Inc.  All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    5252
    5353video:-webkit-full-page-media::-webkit-media-controls-panel {
    54     bottom: -16px;
     54    bottom: 0px;
    5555}
    5656

  • trunk/Source/WebCore/css/mediaControlsEfl.css

    r80809 r83939  
    11/*
    2  * Copyright (C) 2009, 2010 Apple Inc.  All rights reserved.
     2 * Copyright (C) 2009, 2010, 2011 Apple Inc.  All rights reserved.
    33 * Copyright (C) 2011 Samsung Electronics
    44 *
    … …  
    4646
    4747video:-webkit-full-page-media::-webkit-media-controls-panel {
    48     bottom: -25px;
     48    bottom: 0px;
    4949}
    5050

  • trunk/Source/WebCore/css/mediaControlsQuickTime.css

    r67254 r83939  
    11/*
    2  * Copyright (C) 2009, 2010 Apple Inc.  All rights reserved.
     2 * Copyright (C) 2009, 2010, 2011 Apple Inc.  All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    3838
    3939video:-webkit-full-page-media::-webkit-media-controls-panel {
    40     bottom: -25px;
     40    bottom: 0px;
    4141}
    4242
Note: See TracChangeset for help on using the changeset viewer.