Changeset 83943 in webkit

Timestamp:

Apr 14, 2011 10:05:05 PM (13 years ago)

Author:

Beth Dakin

Message:

​https://bugs.webkit.org/show_bug.cgi?id=58612
Crash switching overlay/non-overlay scrollbar preference
(WebCore::Page::setNeedsRecalcStyleInAllFrames + 9)
-and corresponding-
<rdar://problem/9241920>

Reviewed by Adele Peterson.

Speculative fix: Page could definitely be null here.

• page/FrameView.cpp:

(WebCore::FrameView::scrollbarStyleChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-14  Beth Dakin  <bdakin@apple.com>
+
+        Reviewed by Adele Peterson.
+
+        https://bugs.webkit.org/show_bug.cgi?id=58612
+        Crash switching overlay/non-overlay scrollbar preference 
+        (WebCore::Page::setNeedsRecalcStyleInAllFrames + 9)
+        -and corresponding-
+        <rdar://problem/9241920> 
+
+        Speculative fix: Page could definitely be null here. 
+        * page/FrameView.cpp:
+        (WebCore::FrameView::scrollbarStyleChanged):
+
 2011-04-14  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -2112 +2112 @@
 void FrameView::scrollbarStyleChanged()
 {
-    m_frame->page()->setNeedsRecalcStyleInAllFrames();
+    Page* page = m_frame->page();
+    ASSERT(page);
+    if (!page)
+        return;
+    page->setNeedsRecalcStyleInAllFrames();
 }