Changeset 83947 in webkit


Ignore:
Timestamp:
Apr 14, 2011 10:22:30 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-14 Ami Fischman <​fischman@google.com>

Reviewed by Eric Carlson.

Rewrote video-controls-in-media-document layouttest to use the shadow
DOM (possible as of r83397) and avoid the need for pixel-test status.
​https://bugs.webkit.org/show_bug.cgi?id=54634

  • media/video-controls-in-media-document-expected.txt: Added.
  • media/video-controls-in-media-document.html:
  • platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.checksum: Removed.
  • platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.png: Removed.
  • platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.txt: Removed.
  • platform/chromium-win-xp/media/video-controls-in-media-document-expected.checksum: Removed.
  • platform/chromium-win-xp/media/video-controls-in-media-document-expected.png: Removed.
  • platform/chromium/media/video-controls-in-media-document-expected.checksum: Removed.
  • platform/chromium/media/video-controls-in-media-document-expected.png: Removed.
  • platform/chromium/media/video-controls-in-media-document-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/media/video-controls-in-media-document-expected.txt: Removed.
  • platform/mac/Skipped:
  • platform/win/Skipped:
Location:
trunk/LayoutTests
Files:
1 added
9 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83939 r83947  
     12011-04-14  Ami Fischman  <fischman@google.com>
     2
     3        Reviewed by Eric Carlson.
     4
     5        Rewrote video-controls-in-media-document layouttest to use the shadow
     6        DOM (possible as of r83397) and avoid the need for pixel-test status.
     7        https://bugs.webkit.org/show_bug.cgi?id=54634
     8
     9        * media/video-controls-in-media-document-expected.txt: Added.
     10        * media/video-controls-in-media-document.html:
     11        * platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.checksum: Removed.
     12        * platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.png: Removed.
     13        * platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.txt: Removed.
     14        * platform/chromium-win-xp/media/video-controls-in-media-document-expected.checksum: Removed.
     15        * platform/chromium-win-xp/media/video-controls-in-media-document-expected.png: Removed.
     16        * platform/chromium/media/video-controls-in-media-document-expected.checksum: Removed.
     17        * platform/chromium/media/video-controls-in-media-document-expected.png: Removed.
     18        * platform/chromium/media/video-controls-in-media-document-expected.txt: Removed.
     19        * platform/chromium/test_expectations.txt:
     20        * platform/gtk/media/video-controls-in-media-document-expected.txt: Removed.
     21        * platform/mac/Skipped:
     22        * platform/win/Skipped:
     23
    1242011-04-14  Ami Fischman  <fischman@google.com>
    225

  • trunk/LayoutTests/media/video-controls-in-media-document.html

    r80820 r83947  
    22rendered overlapping with the video canvas).<p>
    33<script src="media-file.js" type="text/javascript"></script>
     4<script src="video-test.js" type="text/javascript"></script>
    45
    56<iframe style="width: 400px; height: 300px; border: 0px;" id="container"> </iframe>
    67
    78<script type="text/javascript">
    8 if (window.layoutTestController)
    9     layoutTestController.waitUntilDone();
    10 
    119var iframe = document.getElementById("container");
    12 
    13 function finish() {
    14     // Sadly, "seeked" fires before the canvas is fully repainted or the controls
    15     // finish "fading in", so we have to insert an artificial delay before exiting
    16     // the test.
    17     if (window.layoutTestController)
    18         setTimeout("layoutTestController.notifyDone();", 100);
    19 };
    2010
    2111function timeupdate(event) {
    2212    var video = event.target;
    23     video.addEventListener("seeked", finish);
    24     // In order to get a predictable image (for pixels expectation) we seek to
    25     // time 0.  A simpler and more robust test would simply inspect the height of
    26     // the rendered video+controls but the controls are part of the shadow DOM and
    27     // are not reachable from JS (not even in DumpRenderTree).
    28     video.pause();
    29     video.currentTime = 0;
     13    controls = layoutTestController.shadowRoot(video).firstChild.firstChild;
     14    testExpected("controls.offsetTop + controls.offsetHeight", video.offsetHeight, "<=");
     15    layoutTestController.notifyDone();
    3016};
    3117

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r83937 r83947  
    30613061BUGV8_1168 : fast/js/mozilla/strict/this-for-function-expression-recursion.html = TEXT
    30623062
    3063 BUGWK54634 : media/video-controls-in-media-document.html = IMAGE+TEXT IMAGE PASS
    3064 
    30653063BUGV8_1203 DEBUG : fast/canvas/webgl/gl-get-calls.html = PASS CRASH
    30663064

  • trunk/LayoutTests/platform/mac/Skipped

    r83820 r83947  
    302302fast/js/i18n-bindings-locale.html
    303303
    304 # Waiting for someone with a mac to baseline this (new) test for mac.
    305 # https://bugs.webkit.org/show_bug.cgi?id=54436
    306 media/video-controls-in-media-document.html
    307 
    308304# Non-premultiplied-alpha currently broken on mac.
    309305# https://bugs.webkit.org/show_bug.cgi?id=55509

  • trunk/LayoutTests/platform/win/Skipped

    r83712 r83947  
    410410# Fails (but not on all machines? Or only when run with certain other tests?) http://webkit.org/b/54655
    411411http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html
    412 
    413 # Needs windows-specific pixel results http://webkit.org/b/54757
    414 media/video-controls-in-media-document.html
    415412
    416413# Sometimes fails http://webkit.org/b/55329
Note: See TracChangeset for help on using the changeset viewer.