Changeset 84030 in webkit

Timestamp:

Apr 15, 2011 1:51:24 PM (13 years ago)

Author:

msaboff@apple.com

Message:

2011-04-15 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
​https://bugs.webkit.org/show_bug.cgi?id=58677

Moved JSObjectWithGlobalObject::globalObject() to
runtime/JSObjectWithGlobalObject.h to allow the compiler to inline
it for a performance benefit. An equivalent instance had been in
a header file before r60057.

• JavaScriptCore.exp:
• runtime/JSObjectWithGlobalObject.cpp:
• runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::globalObject):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• Configurations/JavaScriptCore.xcconfig (modified) (1 diff)
• runtime/JSObjectWithGlobalObject.cpp (modified) (1 diff)
• runtime/JSObjectWithGlobalObject.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-04-15  Michael Saboff  <msaboff@apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
+        https://bugs.webkit.org/show_bug.cgi?id=58677
+
+        Moved JSObjectWithGlobalObject::globalObject() to 
+        runtime/JSObjectWithGlobalObject.h to allow the compiler to inline
+        it for a performance benefit.  An equivalent instance had been in
+        a header file before r60057.
+
+        * JavaScriptCore.exp:
+        * runtime/JSObjectWithGlobalObject.cpp:
+        * runtime/JSObjectWithGlobalObject.h:
+        (JSC::JSObjectWithGlobalObject::globalObject):
+
 2011-04-14  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig

@@ -50 +50 @@
 OTHER_CFLAGS_Release_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION));
 OTHER_CFLAGS_Production_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION));
-OTHER_CFLAGS_normal_GCC_42 = -fomit-frame-pointer -funwind-tables;
+// OTHER_CFLAGS_normal_GCC_42 = -fomit-frame-pointer -funwind-tables;
+OTHER_CFLAGS_normal_GCC_42 = -funwind-tables;
 OTHER_CFLAGS_normal_LLVM_GCC_42 = $(OTHER_CFLAGS_normal_GCC_42);

trunk/Source/JavaScriptCore/runtime/JSObjectWithGlobalObject.cpp

@@ -42 +42 @@
 }
 
-JSGlobalObject* JSObjectWithGlobalObject::globalObject() const
-{
-    return asGlobalObject((getAnonymousValue(GlobalObjectSlot).asCell()));
-}
-
 } // namespace JSC

trunk/Source/JavaScriptCore/runtime/JSObjectWithGlobalObject.h

@@ -27 +27 @@
 #define JSObjectWithGlobalObject_h
 
-#include "JSObject.h"
+#include "JSGlobalObject.h"
 
 namespace JSC {
@@ -40 +40 @@
     }
 
-    JSGlobalObject* globalObject() const;
+    JSGlobalObject* globalObject() const
+    {
+        return asGlobalObject((getAnonymousValue(GlobalObjectSlot).asCell()));
+    }
 
 protected: