Changeset 84056 in webkit

Timestamp:

Apr 15, 2011 5:03:05 PM (13 years ago)

Author:

eae@chromium.org

Message:

2011-04-15 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

input field with focus makes appendChild operation ~42x slower
​https://bugs.webkit.org/show_bug.cgi?id=57059

Add performance test for cloneNode when an input field has focus.

• perf/clone-with-focus-expected.txt: Added.
• perf/clone-with-focus.html: Added.

2011-04-15 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

input field with focus makes appendChild operation ~42x slower
​https://bugs.webkit.org/show_bug.cgi?id=57059

Change ContainerNode::cloneChildNodes to only disable the
deleteButtonController if the container itself (or any of its children)
is being edited. Thus avoiding a reflow in cases where it's not.

Test: perf/clone-with-focus.html

• dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/perf/clone-with-focus-expected.txt (added)
• LayoutTests/perf/clone-with-focus.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/ContainerNode.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-15  Emil A Eklund  <eae@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        input field with focus makes appendChild operation ~42x slower
+        https://bugs.webkit.org/show_bug.cgi?id=57059
+
+        Add performance test for cloneNode when an input field has focus.
+
+        * perf/clone-with-focus-expected.txt: Added.
+        * perf/clone-with-focus.html: Added.
+
 2011-04-15  Charlie Reis  <creis@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-15  Emil A Eklund  <eae@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        input field with focus makes appendChild operation ~42x slower
+        https://bugs.webkit.org/show_bug.cgi?id=57059
+
+        Change ContainerNode::cloneChildNodes to only disable the
+        deleteButtonController if the container itself (or any of its children)
+        is being edited. Thus avoiding a reflow in cases where it's not.
+
+        Test: perf/clone-with-focus.html
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::cloneChildNodes):
+
 2011-04-15  Kinuko Yasuda  <kinuko@chromium.org>
 

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -799 +799 @@
 {
     // disable the delete button so it's elements are not serialized into the markup
-    bool isEditorEnabled = document()->frame() && document()->frame()->editor()->canEdit();
-    if (isEditorEnabled)
-        document()->frame()->editor()->deleteButtonController()->disable();
+    bool isEditorEnabled = false;
+    if (document()->frame() && document()->frame()->editor()->canEdit()) {
+        SelectionController* selection = document()->frame()->selection();
+        Element* root = selection ? selection->rootEditableElement() : 0;
+        isEditorEnabled = root && isDescendantOf(root);
+
+        if (isEditorEnabled)
+            document()->frame()->editor()->deleteButtonController()->disable();
+    }
+    
     ExceptionCode ec = 0;
     for (Node* n = firstChild(); n && !ec; n = n->nextSibling())