Changeset 84078 in webkit


Ignore:
Timestamp:
Apr 15, 2011 9:35:54 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-15 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

[Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
https://bugs.webkit.org/show_bug.cgi?id=58717

Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.

  • WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::show):
Location:
trunk/Source/WebKit/mac
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/mac/ChangeLog

    r84072 r84078  
     12011-04-15  Jia Pu  <jpu@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
     6        https://bugs.webkit.org/show_bug.cgi?id=58717
     7
     8        Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
     9
     10        * WebCoreSupport/CorrectionPanel.mm:
     11        (CorrectionPanel::show):
     12
    1132011-04-15  Shishir Agrawal  <shishir@chromium.org>
    214
  • trunk/Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm

    r81896 r84078  
    7676    }
    7777
    78     [[NSSpellChecker sharedSpellChecker] showCorrectionBubbleOfType:bubbleType primaryString:replacementStringAsNSString alternativeStrings:alternativeStrings forStringInRect:boundingBoxOfReplacedString view:m_view.get() completionHandler:^(NSString* acceptedString) {
     78    [[NSSpellChecker sharedSpellChecker] showCorrectionBubbleOfType:bubbleType primaryString:replacementStringAsNSString alternativeStrings:alternativeStrings forStringInRect:[view convertRect:boundingBoxOfReplacedString fromView:nil] view:m_view.get() completionHandler:^(NSString* acceptedString) {
    7979        handleAcceptedReplacement(acceptedString, replacedStringAsNSString, replacementStringAsNSString, bubbleType);
    8080    }];
Note: See TracChangeset for help on using the changeset viewer.