Changeset 84083 in webkit

Timestamp:

Apr 16, 2011 12:28:01 AM (13 years ago)

Author:

ojan@chromium.org

Message:

2011-04-16 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

handle new tests in the new results html file
​https://bugs.webkit.org/show_bug.cgi?id=58715

• Scripts/webkitpy/layout_tests/layout_package/json_results.html:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/layout_package/json_results.html (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-16  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        handle new tests in the new results html file
+        https://bugs.webkit.org/show_bug.cgi?id=58715
+
+        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
+
 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html

@@ -87 +87 @@
 // FIXME: show expected/actual/diff contents inline in iframes
 // FIXME: allow zooming in on pixel diffs
-// FIXME: handle new tests
 
 var hasTextFailures = false;
@@ -95 +94 @@
 
 var testsWithStderr = [];
+var newTests = [];
 var hasHttpTests = false;
 
@@ -104 +104 @@
 
   var actual = results.tests[test].actual;
+  if (actual == 'MISSING') {
+      // FIXME: make sure that new-run-webkit-tests spits out an -actual.txt file for
+      // tests with MISSING results.
+      newTests.push(test);
+      continue;
+  }
+  
   var expected = results.tests[test].expected || 'PASS';
-  
   if (actual == 'PASS' && (!results.uses_expectations_file || expected == 'PASS'))
     continue;
@@ -150 +156 @@
 html += '</tbody></table>'
 
-if (testsWithStderr.length) {
-    testsWithStderr.sort();
-
-    html += '<p>Tests that had stderr output:</p><table id="stderr-table">';
-    for (var i = 0; i < testsWithStderr.length; i++) {
-        var test = testsWithStderr[i];
+function appendTestList(tests, header, tableId, fileSuffix, linkName)
+{
+    tests.sort();
+
+    html += '<p>' + header + '</p><table id="' + tableId + '">';
+    for (var i = 0; i < tests.length; i++) {
+        var test = tests[i];
         html += '<tr><td>' + testLink(test) + '</td>' +
-            '<td>' + resultLink(stripExtension(test), '-stderr.txt', 'stderr') + '</td></tr>';
+            '<td>' + resultLink(stripExtension(test), fileSuffix, linkName) + '</td></tr>';
     }
     html += '</table>'
 }
+
+if (newTests.length)
+    appendTestList(newTests, 'Tests that had no expected results (probably new):', 'new-tests-table', '-actual.txt', 'result');
+
+if (testsWithStderr.length)
+    appendTestList(testsWithStderr, 'Tests that had stderr output:', 'stderr-table', '-stderr.txt', 'stderr');
 
 if (hasHttpTests) {