Changeset 84090 in webkit
- Timestamp:
- Apr 16, 2011 11:37:46 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r84085 r84090 1 2011-04-16 Leo Yang <leoyang.webkit@gmail.com> 2 3 Reviewed by Nikolas Zimmermann. 4 5 ASSERT failure when svg <use> element changes href 6 https://bugs.webkit.org/show_bug.cgi?id=58726 7 8 Test case to verify assertion at line 509 of SVGUseElement.cpp. 9 Test passes if no crash occurs in debug mode. 10 11 * svg/custom/use-crash-when-href-change-expected.txt: Added. 12 * svg/custom/use-crash-when-href-change.svg: Added. 13 1 14 2011-04-16 Abhishek Arya <inferno@chromium.org> 2 15 -
trunk/Source/WebCore/ChangeLog
r84088 r84090 1 2011-04-16 Leo Yang <leoyang.webkit@gmail.com> 2 3 Reviewed by Nikolas Zimmermann. 4 5 ASSERT failure when svg <use> element changes href 6 https://bugs.webkit.org/show_bug.cgi?id=58726 7 8 m_resourceId was not empty after the pending resource 9 becomes available. This will trigger the assertion at 10 line 509 of SVGUseElement.cpp when the <use> element's 11 href becomes empty or invalid. 12 13 This patch makes m_resourceId be empty after the pending 14 resource becomes available to avoid assertion failure. 15 16 Test: svg/custom/use-crash-when-href-change.svg 17 18 * svg/SVGUseElement.cpp: 19 (WebCore::SVGUseElement::buildPendingResource): 20 1 21 2011-04-16 Patrick Gansterer <paroga@webkit.org> 2 22 -
trunk/Source/WebCore/svg/SVGUseElement.cpp
r81950 r84090 476 476 ASSERT(!m_targetElementInstance); 477 477 m_isPendingResource = false; 478 m_resourceId = String(); 478 479 invalidateShadowTree(); 479 480 }
Note: See TracChangeset
for help on using the changeset viewer.