Changeset 84095 in webkit

Timestamp:

Apr 16, 2011 2:22:33 PM (13 years ago)

Author:

andersca@apple.com

Message:

2011-04-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Crash when NPP_Write returns -1 when writing the manual stream
​https://bugs.webkit.org/show_bug.cgi?id=58735
<rdar://problem/9124993>

If NPP_Write returns -1 we must cancel the stream.

• WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::deliverDataToPlugin):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Plugins/Netscape/NetscapePluginStream.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-16  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Crash when NPP_Write returns -1 when writing the manual stream
+        https://bugs.webkit.org/show_bug.cgi?id=58735
+        <rdar://problem/9124993>
+
+        If NPP_Write returns -1 we must cancel the stream.
+
+        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
+        (WebKit::NetscapePluginStream::deliverDataToPlugin):
+
 2011-04-16  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp

@@ -222 +222 @@
         int32_t numBytesWritten = m_plugin->NPP_Write(&m_npStream, m_offset, dataLength, data);
         if (numBytesWritten < 0) {
+            cancel();
             stop(NPRES_NETWORK_ERR);
             return;