Changeset 84113 in webkit

Timestamp:

Apr 17, 2011 4:08:13 PM (13 years ago)

Author:

Patrick Gansterer

Message:

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Remove pthread dependency of GCController
​https://bugs.webkit.org/show_bug.cgi?id=54833

• bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/GCController.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-17  Patrick Gansterer  <paroga@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove pthread dependency of GCController
+        https://bugs.webkit.org/show_bug.cgi?id=54833
+
+        * bindings/js/GCController.cpp:
+        (WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
+
 2011-04-17  Gavin Peters  <gavinp@chromium.org>
 

trunk/Source/WebCore/bindings/js/GCController.cpp

@@ -32 +32 @@
 #include <heap/Heap.h>
 #include <wtf/StdLibExtras.h>
-
-#if USE(PTHREADS)
-#include <pthread.h>
-#endif
 
 using namespace JSC;
@@ -79 +75 @@
 void GCController::garbageCollectOnAlternateThreadForDebugging(bool waitUntilDone)
 {
-#if USE(PTHREADS)
-    pthread_t thread;
-    pthread_create(&thread, NULL, collect, NULL);
+    ThreadIdentifier threadID = createThread(collect, 0, "WebCore: GCController");
 
-    if (waitUntilDone)
-        pthread_join(thread, NULL);
-#endif
+    if (waitUntilDone) {
+        waitForThreadCompletion(threadID, 0);
+        return;
+    }
+
+    detachThread(threadID);
 }