Changeset 84127 in webkit


Ignore:
Timestamp:
Apr 18, 2011 2:45:10 AM (13 years ago)
Author:
loislo@chromium.org
Message:

2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r84112.
http://trac.webkit.org/changeset/84112
https://bugs.webkit.org/show_bug.cgi?id=58770

Chromium linux layout tests are broken. (Requested by loislo2
on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r84115 r84127  
     12011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r84112.
     4        http://trac.webkit.org/changeset/84112
     5        https://bugs.webkit.org/show_bug.cgi?id=58770
     6
     7        Chromium linux layout tests are broken. (Requested by loislo2
     8        on #webkit).
     9
     10        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
     11        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
     12
    1132011-04-17  Daniel Bates  <dbates@webkit.org>
    214
  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py

    r84112 r84127  
    4444    imagehash_mismatch_failure = None
    4545    writer = TestResultWriter(port, root_output_dir, filename)
    46     if driver_output.error:
    47         writer.write_stderr(driver_output.error)
    48 
    4946    for failure in failures:
    5047        # FIXME: Instead of this long 'if' block, each failure class might
     
    158155            fs.write_binary_file(expected_filename, expected)
    159156
    160     def write_stderr(self, error):
    161         fs = self._port._filesystem
    162         filename = self.output_filename("-stderr.txt")
    163         fs.maybe_make_directory(fs.dirname(filename))
    164         fs.write_text_file(filename, error)
    165 
    166157    def write_crash_report(self, error):
    167158        """Write crash information."""
  • trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

    r84112 r84127  
    342342        self.assertEquals([], tests_run)
    343343
    344     def test_stderr_is_saved(self):
    345         fs = port.unit_test_filesystem()
    346         self.assertTrue(passing_run(filesystem=fs))
    347         self.assertEquals(fs.read_text_file('/tmp/layout-test-results/passes/error-stderr.txt'),
    348                           'stuff going to stderr')
    349 
    350344    def test_test_list(self):
    351345        fs = port.unit_test_filesystem()
Note: See TracChangeset for help on using the changeset viewer.